1221104 - Reject Permission API promises with TypeError

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Biru [:poiru]]

`navigator.permissions.query({ name: "foo" })` is rejected with a Exception instead of TypeError.

Comment 1

[Biru [:poiru]]

Attachment: Revoke 'midi' permission queries with TypeError

According to the spec, we should reject unsupported permissions with a
TypeError. This merely removes the 'midi' entry entirely so that we get the
expected behaviour.

Comment 2

[Biru [:poiru]]

Attachment: Throw NS_ERROR_NOT_IMPLEMENTED instead of NS_ERROR_UNEXPECTED for PushPermissionDescriptor.userVisible

This is merely for clarity. The spec does not require a TypeError to be thrown here.

Comment 3

[Biru [:poiru]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8feecfc42ddde37ac5273b98c9f9ce114b86c897
Bug 1221104 - Revoke 'midi' permission queries with TypeError. r=baku

https://hg.mozilla.org/integration/mozilla-inbound/rev/bd9a30ae129298318684ec889b2833e6ccd86dc7
Bug 1221104 - Throw NS_ERROR_NOT_IMPLEMENTED instead of NS_ERROR_UNEXPECTED for PushPermissionDescriptor.userVisible. r=baku

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8feecfc42ddd
https://hg.mozilla.org/mozilla-central/rev/bd9a30ae1292