1221168 - The pen menu item on a given conversation should say "Delete", NOT "Delete conversation"

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P2)

Description

[Romain Testard [:RT]]

Attachment: Capture d’écran 2015-11-03 à 17.24.21.png

Comment 1

[Manuel Casas Barrado [:mancas]]

Attachment: The pen menu item on a given conversation should say "Delete", NOT "Delete conversation"

Mark check that everything is ok, otherwise let me know.

Comment 2

[Manuel Casas Barrado [:mancas]]

Attachment: delete_button.png

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 8683027 [details] [diff] [review]
The pen menu item on a given conversation should say "Delete", NOT "Delete conversation"

Review of attachment 8683027 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/locales/en-US/chrome/browser/loop/loop.properties
@@ +78,5 @@
>  ## LOCALIZATION NOTE (copy_link_menuitem, email_link_menuitem, delete_conversation_menuitem):
>  ## These menu items are displayed from a panel's context menu for a conversation.
>  copy_link_menuitem=Copy Link
>  email_link_menuitem=Email Link
> +delete_conversation_menuitem=Delete

We need to update the string id here as well, due to the change in context:

https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_content_best_practices#Changing_existing_strings

Comment 4

[Manuel Casas Barrado [:mancas]]

Attachment: The pen menu item on a given conversation should say "Delete", NOT "Delete conversation"

I forgot about that! Sorry, the patch updates the string ID now

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 8683552 [details] [diff] [review]
The pen menu item on a given conversation should say "Delete", NOT "Delete conversation"

Review of attachment 8683552 [details] [diff] [review]:
-----------------------------------------------------------------

That's better, thanks.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/e28bbac94d69

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e28bbac94d69