Closed Bug 1221168 Opened 8 years ago Closed 8 years ago

The pen menu item on a given conversation should say "Delete", NOT "Delete conversation"

Categories

(Hello (Loop) :: Client, defect, P2)

Product:
Hello (Loop)
Component:
Client
Type:
defect

Tracking

(firefox45 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla45
Tracking Flags:
Tracking Status
firefox45 --- fixed

People

(Reporter: RT, Assigned: mancas)

References

Details

User Story

We're moving away from the "Conversation" wording in the new user journey. 
Using "Delete" will be more agnostic.

Attachments

(3 files, 1 obsolete file)

Capture d’écran 2015-11-03 à 17.24.21.png
32.25 KB, image/png
Details
delete_button.png
104.90 KB, image/png
sevaan
: ui-review+
Details
The pen menu item on a given conversation should say "Delete", NOT "Delete conversation"
2.94 KB, patch
standard8
: review+
Details | Diff | Splinter Review 
      No description provided.
Blocks: 1209713
Rank: 16
Priority: -- → P2
User Story: (updated)
Assignee: nobody → b.mcb
Mark check that everything is ok, otherwise let me know.
Attachment #8683027 - Flags: review?(standard8)
Attached image delete_button.png — 

        Attachment #8683028 -
        Flags: ui-review?(sfranks)

        Attachment #8683028 -
        Flags: ui-review?(sfranks) → ui-review+

    
    

    
  
Comment on attachment 8683027 [details] [diff] [review]
The pen menu item on a given conversation should say "Delete", NOT "Delete conversation"

Review of attachment 8683027 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/locales/en-US/chrome/browser/loop/loop.properties
@@ +78,5 @@
>  ## LOCALIZATION NOTE (copy_link_menuitem, email_link_menuitem, delete_conversation_menuitem):
>  ## These menu items are displayed from a panel's context menu for a conversation.
>  copy_link_menuitem=Copy Link
>  email_link_menuitem=Email Link
> +delete_conversation_menuitem=Delete

We need to update the string id here as well, due to the change in context:

https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_content_best_practices#Changing_existing_strings

        Attachment #8683027 -
        Flags: review?(standard8) → review-

    
    

    
  


  
I forgot about that! Sorry, the patch updates the string ID now

        Attachment #8683027 -
        Attachment is obsolete: true

        Attachment #8683552 -
        Flags: review?(standard8)

    
    

    
  
Comment on attachment 8683552 [details] [diff] [review]
The pen menu item on a given conversation should say "Delete", NOT "Delete conversation"

Review of attachment 8683552 [details] [diff] [review]:
-----------------------------------------------------------------

That's better, thanks.

        Attachment #8683552 -
        Flags: review?(standard8) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/e28bbac94d69
Status: NEW → RESOLVED
Closed: 8 years ago

          status-firefox45:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45

          You need to log in
          before you can comment on or make changes to this bug.