1221172 - Rewrite select navigation in the header

Status: RESOLVED FIXED

(Socorro :: Webapp, task, P2)

Description

[[DEACTIVATED] Adrian Gaudebert]

The way it works at the moment is full of hacks and means that we cannot easily change the URLs we use.

Comment 1

[[DEACTIVATED] Adrian Gaudebert]

Attachment: Link to Github pull-request: https://github.com/mozilla/socorro/pull/3076

Comment 2

[[DEACTIVATED] Adrian Gaudebert]

Attention QA!

As of this work (if it is accepted), the top-level select-based navigation will change. Until now, it was very inconsistent: 

 * when you changed a product, it would go to the home page
 * when you changed a version, it sometimes went to the current page, sometimes to the home page
 * when you changed a report, it would go to that new report

With the above change, the behavior is much simpler: 

 * when you change any value, it goes to the page defined by the three values (product, version, report)

I have also fixed a few bugs in the navigation, some pages did not correctly set the current version or report. 

The only problem I can foresee with the current state of things is that, if you have selected a version X and a product Y, then you change the product to Z and Z does not have version X, then you'll end up in a 404 page. The user still has the top-level nav to go to a different version, but maybe we can think of a better way to handle this special case. Any suggestions?

Comment 3

[Lonnen :lonnen]

404 makes sense, though a friendlier error would be a redirect to the product page with a note that 'version XX' does not exist or similar. I wouldn't sweat it too much, as long as from the 404 we can quickly change the version to a valid version.

These fixes are a big improvement, but this UI smells bad in general. It is useful for less than half the pages people actually use. It conflicts with the search form fields and the daily form fields, and is ambiguous on the report page. We could work out a way of removing it near term.

Don't let that stop you from landing this, though. +1 on that conceptually, not having looked at the code.

Comment 4

[[DEACTIVATED] Adrian Gaudebert]

I have updated my PR so that a user can never see a 404 using the navigation dropdowns. If a selected version doesn't exist for the selected product, it will automatically redirect to the home page for that product. There is no message though, because it would be a bit too much work for such an edge case.

Comment 5

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/8cfd67cd19f64534f775627237f72f4085670b7a
Fixes bug 1221172 - Top navigation made more flexible and robust. r=peterbe