Add a ByFilename breakdown for JS::ubi::Node censuses

RESOLVED FIXED in Firefox 45

Status

()

Core
JavaScript Engine
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: fitzgen, Assigned: fitzgen)

Tracking

(Blocks: 1 bug)

unspecified
mozilla45
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox45 fixed)

Details

Attachments

(1 attachment)

Comment hidden (empty)
Created attachment 8682566 [details] [diff] [review]
Add a ByFilename breakdown for JS::ubi::Node censuses
Attachment #8682566 - Flags: review?(sphink)
Assignee: nobody → nfitzgerald
Status: NEW → ASSIGNED
Depends on: 1220918, 1220031
Blocks: 961331
No longer depends on: 1220918
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e4051f7875cc
Comment on attachment 8682566 [details] [diff] [review]
Add a ByFilename breakdown for JS::ubi::Node censuses

Review of attachment 8682566 [details] [diff] [review]:
-----------------------------------------------------------------

seems believable

::: js/src/vm/CommonPropertyNames.h
@@ +158,5 @@
>      macro(NFKC, NFKC, "NFKC") \
>      macro(NFKD, NFKD, "NFKD") \
>      macro(nonincrementalReason, nonincrementalReason, "nonincrementalReason") \
> +    macro(noFilename, noFilename, "noFilename") \
> +    macro(noStack, noStack, "noStack")                                  \

extra spaces

::: js/src/vm/UbiNodeCensus.cpp
@@ +317,5 @@
> +    if (!obj)
> +        return nullptr;
> +
> +    for (auto entryPtr = entries.begin(); entryPtr < entries.end(); entryPtr++) {
> +        auto& entry = **entryPtr;

This can't be

  for (auto entry : entries)

somehow?

@@ +769,5 @@
> +
> +  public:
> +    ByFilename(Census& census,
> +                  CountTypePtr& thenType,
> +                  CountTypePtr& noFilenameType)

indentation
Attachment #8682566 - Flags: review?(sphink) → review+
(In reply to Steve Fink [:sfink, :s:] from comment #3)
> ::: js/src/vm/UbiNodeCensus.cpp
> @@ +317,5 @@
> > +    if (!obj)
> > +        return nullptr;
> > +
> > +    for (auto entryPtr = entries.begin(); entryPtr < entries.end(); entryPtr++) {
> > +        auto& entry = **entryPtr;
> 
> This can't be
> 
>   for (auto entry : entries)
> 
> somehow?

For some reason I thought that mozilla::Vector didn't support range based for loops, but it turns out it does! \o/

Comment 5

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/b55c75fb0c20

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b55c75fb0c20
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.