Closed
Bug 1221177
Opened 9 years ago
Closed 9 years ago
Add a ByFilename breakdown for JS::ubi::Node censuses
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla45
Tracking | Status | |
---|---|---|
firefox45 | --- | fixed |
People
(Reporter: fitzgen, Assigned: fitzgen)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
13.53 KB,
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8682566 -
Flags: review?(sphink)
Assignee | ||
Updated•9 years ago
|
Assignee | ||
Updated•9 years ago
|
Blocks: memory-platform
Assignee | ||
Comment 2•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e4051f7875cc
Comment 3•9 years ago
|
||
Comment on attachment 8682566 [details] [diff] [review] Add a ByFilename breakdown for JS::ubi::Node censuses Review of attachment 8682566 [details] [diff] [review]: ----------------------------------------------------------------- seems believable ::: js/src/vm/CommonPropertyNames.h @@ +158,5 @@ > macro(NFKC, NFKC, "NFKC") \ > macro(NFKD, NFKD, "NFKD") \ > macro(nonincrementalReason, nonincrementalReason, "nonincrementalReason") \ > + macro(noFilename, noFilename, "noFilename") \ > + macro(noStack, noStack, "noStack") \ extra spaces ::: js/src/vm/UbiNodeCensus.cpp @@ +317,5 @@ > + if (!obj) > + return nullptr; > + > + for (auto entryPtr = entries.begin(); entryPtr < entries.end(); entryPtr++) { > + auto& entry = **entryPtr; This can't be for (auto entry : entries) somehow? @@ +769,5 @@ > + > + public: > + ByFilename(Census& census, > + CountTypePtr& thenType, > + CountTypePtr& noFilenameType) indentation
Attachment #8682566 -
Flags: review?(sphink) → review+
Assignee | ||
Comment 4•9 years ago
|
||
(In reply to Steve Fink [:sfink, :s:] from comment #3) > ::: js/src/vm/UbiNodeCensus.cpp > @@ +317,5 @@ > > + if (!obj) > > + return nullptr; > > + > > + for (auto entryPtr = entries.begin(); entryPtr < entries.end(); entryPtr++) { > > + auto& entry = **entryPtr; > > This can't be > > for (auto entry : entries) > > somehow? For some reason I thought that mozilla::Vector didn't support range based for loops, but it turns out it does! \o/
Comment 6•9 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b55c75fb0c20
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox45:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in
before you can comment on or make changes to this bug.
Description
•