Closed Bug 1221223 Opened 9 years ago Closed 9 years ago

Remove utm parameter from /choose/ supporting links

Categories

(www.mozilla.org :: Analytics, defect)

Production
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: garethc, Unassigned)

Details

Attachments

(1 file)

Hi, I just noticed that there are some utm parameters on supporting links for the /choose/ page. Specifically, these are the links that appear on /choose/: https://www.mozilla.org/en-US/teach/smarton/tracking/?utm_campaign=fx-fall-15 https://www.mozilla.org/en-US/firefox/private-browsing/?utm_campaign=fx-fall-15 When clicking on these links, the session will not be attributed to the campaign because this utm_campaign parameter needs to be set with the utm_source and utm_medium parameters. Plus, we don't even need to add these parameters to these links because any inbound traffic that is correctly tagged (with all 3 utm parameters) will attribute the entire session to the campaign (which includes users clicking through on these links). Can we please remove? Also, I noticed that these 2 links seem to pointing to the wrong pages...should these be switched?
Regarding the utm parameters, :cmore requested this in https://bugzilla.mozilla.org/show_bug.cgi?id=1213891#c2 I am opening a PR to swap those links now.
Flags: needinfo?(chrismore.bugzilla)
(In reply to Gareth Cull [:garethc] from comment #0) > Also, I noticed that these 2 links seem to pointing to the wrong > pages...should these be switched? Okay, the links are switched back on production. On the plus side, we've had less than 1k views on the /choose/ page. People are asleep in Europe. I'll let you/cmore duke it out over the utm tags.
How difficult would it be to do use the value of utm_source and utm_medium from /choose/ when populating the utm_source and utm_medium on the secondary links on /choose/? The reason I didn't specify the source/medium in bug 1213891 is because it will be different from source and these utm parameters are static. Could we do something like: If url.utm_campaign && url.utm_source && url.utm.medium then {{ url('firefox.private-browsing') }}?utm_campaign=url.utm_campaign&utm_source=url.utm_source&utm_medium=url.utm_medium I normally don't like dynamically passing arguments through because of potential XSS vulnerabilities.
Flags: needinfo?(chrismore.bugzilla)
(In reply to Chris More [:cmore] from comment #4) > How difficult would it be to do use the value of utm_source and utm_medium > from /choose/ when populating the utm_source and utm_medium on the secondary > links on /choose/? > > The reason I didn't specify the source/medium in bug 1213891 is because it > will be different from source and these utm parameters are static. > > Could we do something like: > > If url.utm_campaign && url.utm_source && url.utm.medium then > > {{ url('firefox.private-browsing') > }}?utm_campaign=url.utm_campaign&utm_source=url.utm_source&utm_medium=url. > utm_medium > > I normally don't like dynamically passing arguments through because of > potential XSS vulnerabilities. While it's *possible* to mitigate the XSS risks with that approach, it does add a non-trivial amount of complexity that must be carefully reviewed and tested, and in light of :garethc's point in comment #0 that the user's entire session should already attributed to the campaign, I would much prefer that we remove the utm params from the links as he originally suggested.
Ok, we have a much more simple approach to this problem. Remove the UTM parameter and just pick a simple parameter that doesn't overlap with the UTM ones. { url('firefox.private-browsing') }}?c=fx-fall-15 I just need a parameter to trigger the funnelcake and it could be anything. So, in the PR <a href="{{ url('firefox.private-browsing') }}?c=fx-fall-15" class="more">{{ _('Learn more about this') }}</a> <a href="{{ url('teach.smarton.tracking') }}?c=fx-fall-15" class="more">{{ _('Get smart on data tracking') }}</a> Does that work?
Thanks ck!
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: