Rename "Complete diff" to "Squashed diffs" and remove "Review summary"

RESOLVED FIXED

Status

MozReview
General
P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: mcote, Assigned: mcote)

Tracking

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Another small step towards clarifying/deprecating squashed/parent reviews is to fix those unclear links.  Instead of "Complete diff", I think "Squashed diff" is clearer (and even when it's not, at least it's not actively misleading).  "Review summary" is even less clear, so how about "Squashed diff reviews" (technically it should be "Squashed-diff reviews", I believe, but that's kind of ugly).
(Assignee)

Comment 1

2 years ago
Actually, thinking about this further, I think we should remove "Review summary" altogether.  As I said, it's the most confusing link, and I don't want it to look like we're actually going to stick with parent reviews going forward, which might look like the case if we rename it for clarity.
Summary: Rename parent links to "Squashed diffs" and "Squashed diff reviews" → Rename "Complete diff" to "Squashed diffs" and remove "Review summary"
(Assignee)

Comment 2

2 years ago
Created attachment 8682642 [details]
MozReview Request: mozreview: Rename squashed-diff link; remove "Review summary" link (bug 1221225) r=dminor

mozreview: Rename squashed-diff link; remove "Review summary" link (bug 1221225) r?dminor

"Complete Diff" isn't entirely clear, so rename to "Squashed Diff".
"Review Summary" is completely unclear, and we want to move away from reviews
on the squashed diff, so remove it.
Attachment #8682642 - Flags: review?(dminor)

Updated

2 years ago
Attachment #8682642 - Flags: review?(dminor) → review+

Comment 3

2 years ago
Comment on attachment 8682642 [details]
MozReview Request: mozreview: Rename squashed-diff link; remove "Review summary" link (bug 1221225) r=dminor

https://reviewboard.mozilla.org/r/24123/#review21557

::: pylib/mozreview/mozreview/templates/mozreview/commits.html
(Diff revision 1)
> -    <a href="{{parent_details.get_review_request.get_absolute_url}}">Review Summary</a>

We still have at least two operations that require going to the parent review:

1) Manually editing reviewers
2) Closing a review

As far as I can tell, almost no one does either of these, but removing this link will make it more difficult for those who do.

It would be nice to make it possible to do these things from any child review before removing this link.

Making it possible to edit reviewers from any page is a quick fix I think, I'll file a bug for it. I'm not sure about closing reviewers.
(Assignee)

Comment 4

2 years ago
https://reviewboard.mozilla.org/r/24123/#review21557

> We still have at least two operations that require going to the parent review:
> 
> 1) Manually editing reviewers
> 2) Closing a review
> 
> As far as I can tell, almost no one does either of these, but removing this link will make it more difficult for those who do.
> 
> It would be nice to make it possible to do these things from any child review before removing this link.
> 
> Making it possible to edit reviewers from any page is a quick fix I think, I'll file a bug for it. I'm not sure about closing reviewers.

Both of those are actually available from the parent diff view, so I think we're fine.  However, the Automation menu is missing, so I'll have to include that.
(Assignee)

Comment 5

2 years ago
https://reviewboard.mozilla.org/r/24123/#review21557

> Both of those are actually available from the parent diff view, so I think we're fine.  However, the Automation menu is missing, so I'll have to include that.

Actually, the Automation menu is in every commit's reviews view, so nevermind!
(Assignee)

Comment 6

2 years ago
Comment on attachment 8682642 [details]
MozReview Request: mozreview: Rename squashed-diff link; remove "Review summary" link (bug 1221225) r=dminor

mozreview: Rename squashed-diff link; remove "Review summary" link (bug 1221225) r=dminor

"Complete Diff" isn't entirely clear, so rename to "Squashed Diff".
"Review Summary" is completely unclear, and we want to move away from reviews
on the squashed diff, so remove it.
Attachment #8682642 - Attachment description: MozReview Request: mozreview: Rename squashed-diff link; remove "Review summary" link (bug 1221225) r?dminor → MozReview Request: mozreview: Rename squashed-diff link; remove "Review summary" link (bug 1221225) r=dminor
(Assignee)

Comment 7

2 years ago
http://hg.mozilla.org/hgcustom/version-control-tools/rev/843d4e42554f
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Product: Developer Services → MozReview
You need to log in before you can comment on or make changes to this bug.