1221286 - file sizes formatted as NaN MB on Persian OS (also download and update progress)

Status: RESOLVED DUPLICATE of bug 1201232

(Core :: JavaScript: Internationalization API, defect)

Description

[Amir Farsi]

Attachment: UpdateFfDevEditionNaN.jpg

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:44.0) Gecko/20100101 Firefox/44.0
Build ID: 20151103004217

Steps to reproduce:

I'm using Firefox Developer Edition 44 64 Bit on Windows 10 64 bit.
Please see the attached screenshot.


Actual results:

I opened about window from the common FF menu, and it shows Firefox is updating. But it shows NaN mb from NaN mb for size of reviving update! 


Expected results:

NaN mb should be change to for example 45 mb.

Comment 1

[Amir Farsi]

Please be aware that my Firefox updated, but NaN MB was to the end of update.

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Thank you for the report, this might be a regression from bug 1009795.

http://hg.mozilla.org/mozilla-central/file/f742b9412ed5/browser/base/content/aboutDialog.js#l626
http://hg.mozilla.org/mozilla-central/file/f742b9412ed5/toolkit/mozapps/downloads/DownloadUtils.jsm#l208
http://hg.mozilla.org/mozilla-central/file/f742b9412ed5/toolkit/mozapps/downloads/DownloadUtils.jsm#l458

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Hi Amir, can you tell us please what is set as language and region in the system settings? Thank you.

Comment 4

[Amir Farsi]

Yes. My Preferred language in my system settings is Persian(fa) which is a RTL language.

Comment 5

[Amir Farsi]

But be aware, my Firefox language(Language of UI) is English, but preferred language in Options-->Contents-->Languages is Persian(Farsi)

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

[Tracking Requested - why for this release]:
On Windows with the UI in Persian (fa-IR), all file sizes in the UI shows up as 'NaN': file size when asked where to store a file, in the download progress panel, in the About Firefox update dialog, likely more.
Not to know how big a download is can be painful.

I can't reproduce the issue with Xubuntu in Persian but on Windows 8.1.

Running this script returns NaN if the Windows locale is Persian:

var fractionDigits = 1;
var locale = Intl.NumberFormat().resolvedOptions().locale + "-u-nu-latn";
var formatter = Intl.NumberFormat(locale,
                        { maximumFractionDigits: fractionDigits,
                          minimumFractionDigits: fractionDigits });
formatter.format(55.5)

formatter.format.toString points to numberFormatFormatToBind
https://dxr.mozilla.org/mozilla-central/rev/0c648a1efbe06b5ec866ba058d18256b80808b46/js/src/builtin/Intl.js#2007

So it might fail here:
https://dxr.mozilla.org/mozilla-central/rev/0c648a1efbe06b5ec866ba058d18256b80808b46/js/src/builtin/Intl.cpp#1441

Comment 7

[Amir Farsi]

Attachment: MozAddOnsNaN.jpg

This is screenshot of Firefox when downloading and installing an Add-On. It shows NaN in Addons download pop-up window.
Also I have this problem in download window.
This problem is in any where which Firefox wants to download a file.

Comment 8

[André Bargull [:anba]]

Dup of bug 1201232.

Comment 10

[Liz Henry (:lizzard) (privacy/fingerprinting team)]

Tracking bug 1201232 instead.

Comment 11

[babak]

hi there
I had the same problem by firefox on windows 8.1 with persian language 
this should be solved by changing reginal setting and change customize format of decimal symbol
from "/" character to "." caharacter