1221307 - [fxos-device-service] Modularize routes and tests

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Infrastructure, defect)

Description

[:Eli Perelman]

The routes and tests files are getting a little long and unwieldy. I'd like to see these broken up a bit and become more manageable.

Comment 1

[:Eli Perelman]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/fxos-device-service/pull/13

First patch: modularizes the routing code. Route endpoints are there own files and takes advantage of modular Express router. Also did some clean up with the Express response helpers and associated test changes. Grouped routes with logic, should make creating new routes and logic a little easier with less maintenance.

Comment 2

[:Eli Perelman]

I'll work on the test modularization after the router work has met standards.

Comment 3

[Gareth Aye [:gaye] (back from PTO)]

Comment on attachment 8682795 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/fxos-device-service/pull/13

r+ with a single ocd nit

Comment 4

[:Eli Perelman]

Step 1 in master: https://github.com/mozilla-b2g/fxos-device-service/commit/c9fb6ff2bf838ce252b7d2ae6254f277e3f6f02c

Comment 5

[:Eli Perelman]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/fxos-device-service/pull/14

Step 2: split testing up into separate files.

Comment 6

[Gareth Aye [:gaye] (back from PTO)]

Comment on attachment 8683121 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/fxos-device-service/pull/14

Much better! Not everything can live in the same file :)

Comment 7

[:Eli Perelman]

In master: https://github.com/mozilla-b2g/fxos-device-service/commit/e0b51538b4ae0374aa609d8da88d7efde39561a9

Comment 8

[Gareth Aye [:gaye] (back from PTO)]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/fxos-device-service/pull/18

Comment 9

[Gareth Aye [:gaye] (back from PTO)]

https://github.com/mozilla-b2g/fxos-device-service/commit/8d0758e94153e4d0aad1a6b2402157c3095ae929 landed on master