use Endian.h more widely in bluetooth code

RESOLVED FIXED in Firefox 45

Status

Firefox OS
Bluetooth
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: froydnj, Assigned: froydnj)

Tracking

unspecified
FxOS-S11 (13Nov)

Firefox Tracking Flags

(firefox45 fixed)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

2 years ago
Created attachment 8682797 [details] [diff] [review]
use Endian.h more widely in bluetooth code
Attachment #8682797 - Flags: review?(btian)

Comment 2

2 years ago
Comment on attachment 8682797 [details] [diff] [review]
use Endian.h more widely in bluetooth code

Review of attachment 8682797 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with comment addressed. Thanks for the effort!

::: dom/bluetooth/common/ObexBase.cpp
@@ +5,5 @@
>   * You can obtain one at http://mozilla.org/MPL/2.0/. */
>  
>  #include "ObexBase.h"
>  
> +#include "mozilla/Endian.h"

Remove this inclusion since included ObexBase.h already has it.

::: dom/bluetooth/common/ObexBase.h
@@ +9,5 @@
>  
>  #include "BluetoothCommon.h"
>  #include "nsAutoPtr.h"
>  #include "nsTArray.h"
> +#include "mozilla/Endian.h"

nit: alphabetical order
Attachment #8682797 - Flags: review?(btian) → review+

Comment 3

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/6d42ef0047e7

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/6d42ef0047e7
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S11 (13Nov)
Comment on attachment 8682797 [details] [diff] [review]
use Endian.h more widely in bluetooth code

The attached patch is different from what actually landed. Please attach final versions of the patches before landing them.
You need to log in before you can comment on or make changes to this bug.