Closed Bug 1221420 Opened 9 years ago Closed 9 years ago

[TV Browser] Failed to go back to the previous screen after tapping the Back button in "Inactive Account" page

Categories

(Firefox OS Graveyard :: Gaia::TV::System, defect, P3)

Product:
Firefox OS Graveyard
Component:
Gaia::TV::System
Platform:
ARM
Gonk (Firefox OS)
Type:
defect

Tracking

(blocking-b2g:2.5+, b2g-v2.5 fixed, b2g-master fixed)

Status:
VERIFIED FIXED
Milestone:
FxOS-S11 (13Nov)
Project Flags:
blocking-b2g 2.5+
Tracking Flags:
Tracking Status
b2g-v2.5 --- fixed
b2g-master --- fixed

People

(Reporter: cynthiatang, Assigned: yifan)

References

Details

(Whiteboard: [ft:conndevices][partner-cherry-pick])

Attachments

(2 files)

Screen Shot
104.91 KB, image/png
Details
[gaia] begeeben:1221420_failed_to_go_back > mozilla-b2g:master
46 bytes, text/x-github-pull-request
ferjm
: review+
jocheng
: approval-gaia-v2.5+
Details | Review
Attached image Screen Shot — 
Commit f17421e9a23b9dbd88c41347f1b9c442a97f48e0
Merge: 06de78d e7dd557
Author: gasolin <gasolin@gmail.com>
Date:   Tue Nov 3 13:37:26 2015 +0800

STR:
Commit f17421e9a23b9dbd88c41347f1b9c442a97f48e0
Merge: 06de78d e7dd557
Author: gasolin <gasolin@gmail.com>
Date:   Tue Nov 3 13:37:26 2015 +0800

STR:
 1. Launch Browser
 2. Move cursor to Menu icon and press OK 
 3. Select "Sign in to Sync" and press OK
 4. Enter your firefox account and press OK
 5. Enter the invalid password and press OK
 5. Press Back on the remote control 
    (Press ESC key on the physical keyboard)

Expected Result:
 - Close the window that shows "Invalid Password"
 - Go back to the previous screen

Actual Result:
 - Please see the attachment
QA Whiteboard: [COM=TV Firefox Account]
We need to disable the ESC key on the error screen. YiFan could you take a look at this, please? Thanks!
Blocks: fxos-sync
Flags: needinfo?(yliao)
Priority: -- → P3
Target Milestone: --- → FxOS-S11 (13Nov)
Assignee: nobody → yliao
Status: NEW → ASSIGNED
Flags: needinfo?(yliao)
Attachment #8684074 - Flags: review?(ferjmoreno)
Attachment #8684074 - Flags: review?(ferjmoreno) → review+
https://github.com/mozilla-b2g/gaia/commit/ff24d878436770957bd70ba4d2e41df9c148a1c1
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [ft:conndevices] → [ft:conndevices][partner-cherry-pick]
Comment on attachment 8684074 [details] [review]
[gaia] begeeben:1221420_failed_to_go_back > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): 1194108
[User impact] if declined: No response pressing the back button on a remote control.
[Testing completed]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=52051096e378a5c7db1c2c3a1a4a55a38d8c6c20
[Risk to taking this patch] (and alternatives if risky): none
[String changes made]: none
Attachment #8684074 - Flags: approval-gaia-v2.5?
blocking-b2g: --- → 2.5+
Comment on attachment 8684074 [details] [review]
[gaia] begeeben:1221420_failed_to_go_back > mozilla-b2g:master

Approve as this is required for TV 2.5 FxA feature.
Attachment #8684074 - Flags: approval-gaia-v2.5? → approval-gaia-v2.5+
Blocks: 1227013
Component: Gaia::TV::Browser → Gaia::TV::System
Verify this issue on the latest build.
Pressing the Backspace key can close the window that shows "Invalid Password", and then goes back to the previous screen.

[Build Info]
Environment: Simulator 2.5.20160215231509
gaia:
https://github.com/mozilla-b2g/gaia/commit/b059a19c4cb615e16174735662199e6769cee393
gecko:
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/227c6d4926c154167a2214e123253f2c937e4106
mulet:
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/9d519d3bedacb7f5ce467f4c6bef7ff55ff3b0f3

[Build Info]
Environment: Simulator 2.6.20160222133739
gaia:
https://github.com/mozilla-b2g/gaia/commit/435a9320454ccc3ffdebff4d5d680f1254a15e26
gecko:
https://hg.mozilla.org/mozilla-central/rev/a9e33d8c48b5ca93ca1937eba4220f681a0f05ec
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: