1221439 - [TV Browser] Missing the "x" button to clean the password in Firefox Account - Sign In page

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::TV::Browser, defect, P2)

Description

[Cynthia Tang [:cynthiatang]]

Attachment: [TV]FirefoxAccount_v0.5

Commit f17421e9a23b9dbd88c41347f1b9c442a97f48e0
Merge: 06de78d e7dd557
Author: gasolin <[e-mail]>
Date:   Tue Nov 3 13:37:26 2015 +0800

STR:
 1. Launch Browser
 2. Select "Sign in to Sync"
 3. Enter your Firefox Account

Expected Result:
 - There should be "x" buttons for cleaning the password
 - Please refer [TV]FirefoxAccount_v0.5, page 7

Actual Result:
 - There is no "x" button

Comment 1

[Evelyn Hung]

Function missing, set it to higher priority.

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] begeeben:1221439_missing_the_x > mozilla-b2g:master

Comment 3

[yifan [:yifan][:yliao]]

Comment on attachment 8692394 [details] [review]
[gaia] begeeben:1221439_missing_the_x > mozilla-b2g:master

Added X buttons for password input and auth refresh pages in the fx account sign in flow.

Comment 4

[Sean Lee [:seanlee][:weilonge]]

Comment on attachment 8692394 [details] [review]
[gaia] begeeben:1221439_missing_the_x > mozilla-b2g:master

Hi Yifan, Thanks for your effort and LGTM! I leave some comments to make the style consistent. However, it's a minor change that we can discuss then.

Comment 5

[yifan [:yifan][:yliao]]

Merged into master:
https://github.com/mozilla-b2g/gaia/commit/c8523081ce9594ca2c383bf5c76315c1f6ce0235

Comment 6

[yifan [:yifan][:yliao]]

Comment on attachment 8692394 [details] [review]
[gaia] begeeben:1221439_missing_the_x > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): 1194108
[User impact] if declined: No button to clear password input
[Testing completed]: Manual test thoroughly
[Risk to taking this patch] (and alternatives if risky): none
[String changes made]: none

Comment 7

[Josh Cheng [:josh]]

Comment on attachment 8692394 [details] [review]
[gaia] begeeben:1221439_missing_the_x > mozilla-b2g:master

Approve fro TV 2.5 FxA

Comment 8

[Carsten Book [:Tomcat]]

for 2.5 https://github.com/mozilla-b2g/gaia/commit/405971b7aeb84b7fe51511900f3fe45e01205733

Comment 9

[Rid Pan]

Verify this issue on the latest build.
The "X" button shows up after inputting words into the password column. And tapping the "X" button can clear the password column.
[Build Info]
Environment: 2.6 Simulator
gaia:
https://github.com/mozilla-b2g/gaia/commit/d9faad5c0f14fcd42f920c9104f0638f46a48b2a
gecko:
https://hg.mozilla.org/mozilla-central/rev/789a12291942763bc1e3a89f97e0b82dc1c9d00b