122144 - [FIX] disable 'Translate' menu item for images

Status: VERIFIED FIXED

Description

[Adam Hauner]

Translation of image is still irelevant (AFAIK there isn't any translator with
built-in OCR), so this menu item should be disabled for them (actually does
nothing or just redirecting).

Gecko/2002012608/WinNT4

Comment 1

[timeless]

hrm

Comment 2

[Jesse Ruderman]

The mimetype-exposing code added in bug 73847 may be useful here.

Comment 3

[sairuh (rarely reading bugmail)]

->morse, who's working on menu items.

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

taking

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

Created attachment 69949 [details] [diff] [review]
patch

Comment 6

[Blake Ross]

Comment on attachment 69949 [details] [diff] [review]
patch

sr=blake

This should not visibly affect page load times at all.	If for any reason it
does, of course, we'll have to back it out.

Comment 7

[timeless]

Comment on attachment 69949 [details] [diff] [review]
patch

biesi will fix whitespace and change the regexp to ^image/

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

putting [FIX] in summary instead of URL field

Comment 9

[Christian :Biesinger (don't email me, ping me on IRC)]

fixed

Comment 10

[Christian :Biesinger (don't email me, ping me on IRC)]

Created attachment 69982 [details] [diff] [review]
fixes strict warning

ok, the patch introduced a strict warning. this patch fixes it.

Comment 11

[Henrik Gemal]

is there another patch for disable to Text Zoom too for images?

Comment 12

[Blake Ross]

Comment on attachment 69982 [details] [diff] [review]
fixes strict warning

sr=blake

Comment 13

[Henrik Gemal]

i've filed http://bugzilla.mozilla.org/show_bug.cgi?id=126059 on more disable 
on images

Comment 14

[Boris Zbarsky [:bzbarsky, bz on IRC]]

Does this need to be reopened?  It's been backed out, right?

Comment 15

[Christian :Biesinger (don't email me, ping me on IRC)]

yes, it was backed out, but I checked it in again when the backout showed no
changes to Txul time.

Comment 16

[Olli Pettay [:smaug] (r- if the bug doesn't explain what the change(s) are about.)]

(Maybe) Because of this patch, I'm getting a Javascript-error, 
which says there is something wrong in nsBrowserStatusHandler.js line 256.

The problem is that sometimes the throbberElement remains in busy-state.

If I change "ctype = aRequest.QueryInterface(nsIChannel).contentType;"
to "try{ ctype = aRequest.QueryInterface(nsIChannel).contentType;} catch(ex){}"
the throbber works as expected.

Comment 17

[Christian :Biesinger (don't email me, ping me on IRC)]

smaug: *sigh*. ok, I will fix this as part of bug 126059

Comment 18

[sairuh (rarely reading bugmail)]

vrfy'd for at least the Translate item... :)

*zap*