Closed
Bug 122144
Opened 23 years ago
Closed 23 years ago
[FIX] disable 'Translate' menu item for images
Categories
(SeaMonkey :: UI Design, defect)
SeaMonkey
UI Design
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla0.9.9
People
(Reporter: aha, Assigned: Biesinger)
References
()
Details
Attachments
(1 file, 1 obsolete file)
1.53 KB,
patch
|
timeless
:
review+
bugzilla
:
superreview+
|
Details | Diff | Splinter Review |
Translation of image is still irelevant (AFAIK there isn't any translator with
built-in OCR), so this menu item should be disabled for them (actually does
nothing or just redirecting).
Gecko/2002012608/WinNT4
hrm
Assignee: asa → blaker
Component: Browser-General → XP Apps: GUI Features
QA Contact: doronr → sairuh
Comment 2•23 years ago
|
||
The mimetype-exposing code added in bug 73847 may be useful here.
Depends on: 73847
![]() |
||
Updated•23 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows NT → All
Hardware: PC → All
Updated•23 years ago
|
Target Milestone: --- → Future
Comment 3•23 years ago
|
||
->morse, who's working on menu items.
Assignee: blaker → morse
Blocks: 108099
Assignee | ||
Comment 4•23 years ago
|
||
taking
Assignee: morse → cbiesinger
Target Milestone: Future → mozilla0.9.9
Assignee | ||
Comment 5•23 years ago
|
||
Assignee | ||
Updated•23 years ago
|
Status: NEW → ASSIGNED
Comment 6•23 years ago
|
||
Comment on attachment 69949 [details] [diff] [review]
patch
sr=blake
This should not visibly affect page load times at all. If for any reason it
does, of course, we'll have to back it out.
Attachment #69949 -
Flags: superreview+
Comment on attachment 69949 [details] [diff] [review]
patch
biesi will fix whitespace and change the regexp to ^image/
Attachment #69949 -
Flags: review+
Assignee | ||
Comment 8•23 years ago
|
||
putting [FIX] in summary instead of URL field
Summary: disable 'Translate' menu item for images → [FIX] disable 'Translate' menu item for images
Assignee | ||
Comment 9•23 years ago
|
||
fixed
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 10•23 years ago
|
||
ok, the patch introduced a strict warning. this patch fixes it.
Attachment #69949 -
Attachment is obsolete: true
Comment 11•23 years ago
|
||
is there another patch for disable to Text Zoom too for images?
Attachment #69982 -
Flags: review+
Comment 12•23 years ago
|
||
Comment on attachment 69982 [details] [diff] [review]
fixes strict warning
sr=blake
Attachment #69982 -
Flags: superreview+
Comment 13•23 years ago
|
||
i've filed http://bugzilla.mozilla.org/show_bug.cgi?id=126059 on more disable
on images
![]() |
||
Comment 14•23 years ago
|
||
Does this need to be reopened? It's been backed out, right?
Assignee | ||
Comment 15•23 years ago
|
||
yes, it was backed out, but I checked it in again when the backout showed no
changes to Txul time.
Comment 16•23 years ago
|
||
(Maybe) Because of this patch, I'm getting a Javascript-error,
which says there is something wrong in nsBrowserStatusHandler.js line 256.
The problem is that sometimes the throbberElement remains in busy-state.
If I change "ctype = aRequest.QueryInterface(nsIChannel).contentType;"
to "try{ ctype = aRequest.QueryInterface(nsIChannel).contentType;} catch(ex){}"
the throbber works as expected.
Assignee | ||
Comment 17•23 years ago
|
||
smaug: *sigh*. ok, I will fix this as part of bug 126059
Comment 18•23 years ago
|
||
vrfy'd for at least the Translate item... :)
*zap*
Status: RESOLVED → VERIFIED
Updated•21 years ago
|
Product: Core → Mozilla Application Suite
You need to log in
before you can comment on or make changes to this bug.
Description
•