1221472 - [TV Browser] Some histories show only URLs with blank title

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TV::Browser, defect, P1)

Description

[Cynthia Tang [:cynthiatang]]

Commit f17421e9a23b9dbd88c41347f1b9c442a97f48e0
Merge: 06de78d e7dd557
Author: gasolin <[e-mail]>
Date:   Tue Nov 3 13:37:26 2015 +0800

STR:
 1. Launch Browser
 2. Sign in to sync History
 3. Check the history

Actual Result:
 - Some histories show only URLs without titles

Expected Result:
 - Desktop's history and TV's history should be the same

Comment 1

[Fernando Jiménez Moreno [:ferjm]]

Sean, could you take a look at this, please? Thanks!

Comment 2

[Sean Lee [:seanlee][:weilonge]]

Got it!

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] weilonge:seanlee/TVBrowser/master/Bug1221472 > mozilla-b2g:master

Comment 4

[Sean Lee [:seanlee][:weilonge]]

Comment on attachment 8683147 [details] [review]
[gaia] weilonge:seanlee/TVBrowser/master/Bug1221472 > mozilla-b2g:master

Hey Dan, Could you help to review the patch? Thank you!

Comment 5

[Dan Huang[:danhuang]]

Comment on attachment 8683147 [details] [review]
[gaia] weilonge:seanlee/TVBrowser/master/Bug1221472 > mozilla-b2g:master

Look good to me! Thanks for the effort!

Comment 6

[Sean Lee [:seanlee][:weilonge]]

Thanks for reviewing this! :)

landed on master: https://github.com/mozilla-b2g/gaia/commit/8950676a273bd902a9ae63d7ef9afc59e14ebd81
gaia-test: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=4e30caa53692f37822ef0abcdb4caaf824be14d5

Comment 7

[Sean Lee [:seanlee][:weilonge]]

Comment on attachment 8683147 [details] [review]
[gaia] weilonge:seanlee/TVBrowser/master/Bug1221472 > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): bug 1194108
[User impact] if declined: See the blank title of a history record without title.
[Testing completed]: Tested in B2G desktop build.
[Risk to taking this patch] (and alternatives if risky): None
[String changes made]: None

Comment 8

[Mahendra Potharaju [:mahe]]

Comment on attachment 8683147 [details] [review]
[gaia] weilonge:seanlee/TVBrowser/master/Bug1221472 > mozilla-b2g:master

Approved for 2.5 uplift.

Thanks

Comment 9

[Carsten Book [:Tomcat]]

2.5 -> https://github.com/mozilla-b2g/gaia/commit/1735640e078677ea5fff7bcfab893cf8f964e7ed