1221542 - crash in mozilla::a11y::DocAccessible::SeizeChild

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[David Bolter [:davidb] (NeedInfo me for attention)]

This bug was filed from the Socorro interface and is 
report bp-e7cef379-2783-41c3-9762-b32a12151101.
=============================================================

More here: https://crash-stats.mozilla.com/report/list?product=Firefox&signature=mozilla%3A%3Aa11y%3A%3ADocAccessible%3A%3ASeizeChild

Comment 1

[alexander :surkov (:asurkov)]

Attachment: patch

no good ideas so far, so null checks + assertions, hope to see it in wild

Comment 2

[alexander :surkov (:asurkov)]

Comment on attachment 8683771 [details] [diff] [review]
patch

Review of attachment 8683771 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/generic/DocAccessible.cpp
@@ +2165,5 @@
>        Accessible* owner = child->Parent();
> +      if (!owner) {
> +        NS_ERROR("Cannot put the child back. No parent, a broken tree.");
> +        continue;
> +      }

for bug 1221543

::: accessible/windows/ia2/ia2Accessible.cpp
@@ +665,5 @@
>    Accessible* child = accWithCaret;
>    while (!child->IsDoc() && child != acc)
>      child = child->Parent();
>  
> +  if (child != acc)

artifiact from previous patch, removed

Comment 3

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 8683771 [details] [diff] [review]
patch

Review of attachment 8683771 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/generic/DocAccessible.cpp
@@ +2072,5 @@
>                            int32_t aIdxInParent)
>  {
>    Accessible* oldParent = aChild->Parent();
> +  if (!oldParent) {
> +    NS_ERROR("No parent? The tree is broken!");

On windows will this end up as a dialog box the user reads? If so, I don't know if we'll catch it in the wild...

Comment 4

[alexander :surkov (:asurkov)]

(In reply to David Bolter [:davidb] from comment #3)

> >    Accessible* oldParent = aChild->Parent();
> > +  if (!oldParent) {
> > +    NS_ERROR("No parent? The tree is broken!");
> 
> On windows will this end up as a dialog box the user reads? If so, I don't
> know if we'll catch it in the wild...

on debug only I think (which is controlled by a preference iirc), maybe we will be lucky and handle that one day in testing

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d07c33d0854c

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d07c33d0854c