1221552 - [translate] Improve quality checks

Status: RESOLVED MOVED

(Webtools Graveyard :: Pontoon, defect, P3)

Description

[Matjaz Horvat [:mathjazz]]

Our quality checks have two issues:

1) There are a lot of false positives.
2) They only show warnings, which users can easily ignore.

Our current implementation uses POfilter tests:
http://translate-toolkit.readthedocs.org/en/latest/commands/pofilter_tests.html

Many Mozilla sites use dennis to prevent bad translations from causing errors in production, so we should look into its API and use it:
https://dennis.readthedocs.org/

We should split tests into different categories by importance (POfilter supports that), something like:

A) COSMETIC: These tests should be removed.
B) WARNING: We show a warning, which can be ignored.
C) ERROR: We prevent translation from being submitted. If detected on import, store it as suggestions.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

As a note, I maintain Dennis which makes it easier to fix Dennis to meet additional needs.

Comment 2

[Vee Satayamas]

I found 2-3 false positive errors per one Thai string. It would be nice if Quality Checks is disable by default for Thai since it may prevent people from contributing.

Comment 4

[Matjaz Horvat [:mathjazz]]

As pointed out by tomer in bug 1298852, we should also:

1) Allow team managers to turn specific checks on and off for their locale/project. 
2) Add additional checks like spell checking or something like languagetool.org.

Comment 5

[Matjaz Horvat [:mathjazz]]

As pointed out by Michak in bug 1342568, we should also highlight the error in the translation, to help users identify their mistakes.

Comment 9

[BMO Automation]

*This bug has been moved to GitHub.*

*Please check it out on https://github.com/mozilla/pontoon/issues.*