1221608 - [meta] Spotlight integration

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[James Hugman [:jhugman] [@jhugman]]

Initial pass on this would be to get open tabs into Spotlight. 

Followups might include indexing on device history and tab content.

Theme: iOS9 integration.

Comment 1

[James Hugman [:jhugman] [@jhugman]]

Attachment: Simulator Screen Shot Nov 23, 2015, 8.24.31 PM.png

There doesn't seem to be a lot of UI here. 

What should the Firefox icons be replaced with?

Obvious choices: favicons, screenshots.

Comment 2

[James Hugman [:jhugman] [@jhugman]]

Attachment: Simulator Screen Shot Nov 23, 2015, 8.29.07 PM.png

Search results next to other favicons provided by the iOS on the simulator.

Comment 3

[Darrin Henein [:darrin]]

Comment on attachment 8690985 [details]
Simulator Screen Shot Nov 23, 2015, 8.24.31 PM.png

Hmm. Screenshots would be nice but maybe small in this context (they seem to have a fixed width)?

Favicons may be small, too... might be nice to see/test these options. Let's see what Robin says as well.

Can the subtitle in the other screenshot say "Firefox — {domain.com here}"

Comment 4

[James Hugman [:jhugman] [@jhugman]]

Attachment: Simulator Screen Shot Dec 9, 2015, 4.55.01 PM.png

The "fennec (jhugman)" text is taken from the app name.

Comment 5

[Robin Andersen [:tecgirl]]

Comment on attachment 8697101 [details]
Simulator Screen Shot Dec 9, 2015, 4.55.01 PM.png

LGTM!

Definitely prefer favicons over screenshots.

Comment 6

[James Hugman [:jhugman] [@jhugman]]

Attachment: Pull request

Comment 7

[James Hugman [:jhugman] [@jhugman]]

Comment on attachment 8697420 [details] [review]
Pull request

Added :st3fan for feedback.

Comment 8

[Stephan Leroux [:sleroux]]

Comment on attachment 8697420 [details] [review]
Pull request

This is pretty cool! Left some comments on the PR.

Also noticed that when selecting a search result from spotlight it opens the link in a new tab and not in the existing tab. Is that expected?

Comment 9

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

(In reply to Stephan Leroux [:sleroux] from comment #8)
> Also noticed that when selecting a search result from spotlight it opens the
> link in a new tab and not in the existing tab. Is that expected?

No that sounds like a bug. The Quick Search results should mirror the open tabs in Firefox. So selecting a result should simply open the existing tab. Not a new one.

Comment 10

[James Hugman [:jhugman] [@jhugman]]

:sleroux, :st3fan Can't reproduce on iPhone device or simulator. 

https://github.com/mozilla/firefox-ios/blob/8926b04d754aceb4a2bfaa9a7661178458d07570/Client/Frontend/Browser/BrowserViewController.swift#L886

Comment 11

[James Hugman [:jhugman] [@jhugman]]

Comment on attachment 8697420 [details] [review]
Pull request

I'd like to land this to get more people to find bugs.

There are at least two issues which are increasingly out of scope of this bug.

Comment 12

[Emily Toop (:fluffyemily)]

Comment on attachment 8697420 [details] [review]
Pull request

A couple of comments on PR but essentially :+1:

(It's a really cool feature, I love it :) )

Comment 13

[James Hugman [:jhugman] [@jhugman]]

Nits addressed, and merged. 

Followups filed.

Comment 14

[Aaron Train [:aaronmt]]

Testing this out on master (01/14)

Working great thus far, verification testing

Questions:

 * Queries yielding both or either 'Top Hits' (app icon/site) vs just our application 'Fennec' (app icon/site); what's the differentiator here?

 * Most queries just yielding the application icon and not the site icon – does it take a while for this metadata to get pulled in?

Comment 15

[James Hugman [:jhugman] [@jhugman]]

I saw the icons not appearing on first visit, and have filed Bug 1239028.

The search query processing and search results aren't anything we do. I filed Bug 1239023 to explore how we can change our ranking. Top Hits, afaik is based on frequency of usage, though it's difficult to definitively know.