Closed Bug 122167 Opened 23 years ago Closed 22 years ago

string.replace() placeholder '$1' not working

Categories

(Rhino Graveyard :: Core, defect)

Product:
Rhino Graveyard
Component:
Core
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: pschwartau, Assigned: rogerl)

Details

Attachments

(1 file, 1 obsolete file)

Patch to fix #122167
806 bytes, patch
Details | Diff | Splinter Review 
This is the Rhino version of bug 104375 against SpiderMonkey.
The testcase for this is 

            mozilla/js/tests/ecma_3/String/regress-104375.js
I hit this bug so I thought I'd fix it.

Using the spidermonkey fix, I produced the patch attached. Rhino passes
ecma_3/String/regress-104385 after applying.
Attachment #88787 - Attachment is obsolete: true
Sorry last diff was wrong..
I just checked in a fix for this (pretty much ditto your patch) since I was 
just all over the RegExp stuff; sorry to tread on your toes.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Verified Fixed. With the new RegExp engine in Rhino (see bug 153223)
the above testcase passes in both compiled and interpreted modes.

Morten: thank you for your interest in this!
Status: RESOLVED → VERIFIED
Targeting as resolved against 1.5R4
Target Milestone: --- → 1.5R4
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: