string.replace() placeholder '$1' not working

VERIFIED FIXED in 1.5R4

Status

Rhino
Core
VERIFIED FIXED
16 years ago
14 years ago

People

(Reporter: Phil Schwartau, Assigned: rogerl (gone))

Tracking

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

16 years ago
This is the Rhino version of bug 104375 against SpiderMonkey.
The testcase for this is 

            mozilla/js/tests/ecma_3/String/regress-104375.js

Comment 1

16 years ago
Created attachment 88787 [details] [diff] [review]
Patch to RegExpImpl.java to fig #122167

I hit this bug so I thought I'd fix it.

Using the spidermonkey fix, I produced the patch attached. Rhino passes
ecma_3/String/regress-104385 after applying.

Updated

16 years ago
Attachment #88787 - Attachment is obsolete: true

Comment 2

16 years ago
Created attachment 88788 [details] [diff] [review]
Patch to fix #122167

Sorry last diff was wrong..
(Assignee)

Comment 3

16 years ago
I just checked in a fix for this (pretty much ditto your patch) since I was 
just all over the RegExp stuff; sorry to tread on your toes.
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
(Reporter)

Comment 4

16 years ago
Verified Fixed. With the new RegExp engine in Rhino (see bug 153223)
the above testcase passes in both compiled and interpreted modes.

Morten: thank you for your interest in this!
Status: RESOLVED → VERIFIED

Comment 5

14 years ago
Targeting as resolved against 1.5R4
Target Milestone: --- → 1.5R4
You need to log in before you can comment on or make changes to this bug.