Closed Bug 1221673 Opened 7 years ago Closed 7 years ago

Add support for filtering censuses to memory tool's frontend

Categories

(DevTools :: Memory, defect)

defect
Not set
normal

Tracking

(firefox45 fixed, relnote-firefox 45+)

RESOLVED FIXED
Firefox 45
Tracking Status
firefox45 --- fixed
relnote-firefox --- 45+

People

(Reporter: fitzgen, Assigned: fitzgen)

References

(Blocks 2 open bugs)

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

No description provided.
Assignee: nobody → nfitzgerald
Status: NEW → ASSIGNED
Comment on attachment 8683225 [details] [diff] [review]
Add support for filtering censuses to memory tool's frontend

Victor for css changes.
Attachment #8683225 - Flags: review?(vporof)
Depends on: 1221360
Attachment #8683225 - Flags: review?(vporof) → review+
Comment on attachment 8683225 [details] [diff] [review]
Add support for filtering censuses to memory tool's frontend

Review of attachment 8683225 [details] [diff] [review]:
-----------------------------------------------------------------

If there's an easy way to do a mochitest for this as well, let's do it or file a follow up

::: browser/locales/en-US/chrome/browser/devtools/memory.properties
@@ +49,5 @@
>  take-snapshot=Take snapshot
>  
> +# LOCALIZATION NOTE (filter.placeholder): The placeholder text used for the
> +# memory tool's filter search box.
> +filter.placeholder=Filter

console has a similar filter, l10n: "Filter output" -- I wonder if this should be similar, "Filter <rows>"
Attachment #8683225 - Flags: review?(jsantell) → review+
(In reply to Jordan Santell [:jsantell] [@jsantell] (Please needinfo) from comment #4)
> Comment on attachment 8683225 [details] [diff] [review]
> Add support for filtering censuses to memory tool's frontend
> 
> Review of attachment 8683225 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> If there's an easy way to do a mochitest for this as well, let's do it or
> file a follow up

Did it in this push.
https://hg.mozilla.org/mozilla-central/rev/c3140db8deba
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
Depends on: 1222417
I've added a short note on this: https://developer.mozilla.org/en-US/docs/Tools/Memory#Analyzing_a_snapshot. Not sure if we need anything more extensive?
Flags: needinfo?(nfitzgerald)
Release Note Request (optional, but appreciated)
[Why is this notable]: new functionality for memory tool
[Suggested wording]: Ability to filter snapshot output in memory tool
[Links (documentation, blog post, etc)]:
relnote-firefox: --- → ?
(In reply to Will Bamberg [:wbamberg] from comment #8)
> I've added a short note on this:
> https://developer.mozilla.org/en-US/docs/Tools/Memory#Analyzing_a_snapshot.
> Not sure if we need anything more extensive?

I think this feature is necessary for good usability, but I agree that it is difficult to find a compelling example for documentation. One example might be searching for your CDN's hostname to see all the structures in memory that were created by third party libraries (when combined with allocation stack recording). A similar workflow is employed by the L20N.js developers whose script is designed to be embedded in other people's apps. They don't care about overall memory consumption on the page, just the bits related to their code, so they record allocation stacks and then filter for "L20N.js" to show only the things allocated with their script on the stack.
Flags: needinfo?(nfitzgerald)
Added to the release notes with Tim's wording (thanks!)
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.