1221673 - Add support for filtering censuses to memory tool's frontend

Status: RESOLVED FIXED

(DevTools :: Memory, defect)

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Add support for filtering censuses to memory tool's frontend

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Comment on attachment 8683225 [details] [diff] [review]
Add support for filtering censuses to memory tool's frontend

Victor for css changes.

Comment 3

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7f9e744b491c

Comment 4

[Jordan Santell [:jsantell] [@jsantell]]

Comment on attachment 8683225 [details] [diff] [review]
Add support for filtering censuses to memory tool's frontend

Review of attachment 8683225 [details] [diff] [review]:
-----------------------------------------------------------------

If there's an easy way to do a mochitest for this as well, let's do it or file a follow up

::: browser/locales/en-US/chrome/browser/devtools/memory.properties
@@ +49,5 @@
>  take-snapshot=Take snapshot
>  
> +# LOCALIZATION NOTE (filter.placeholder): The placeholder text used for the
> +# memory tool's filter search box.
> +filter.placeholder=Filter

console has a similar filter, l10n: "Filter output" -- I wonder if this should be similar, "Filter <rows>"

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/c3140db8deba

Comment 6

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

(In reply to Jordan Santell [:jsantell] [@jsantell] (Please needinfo) from comment #4)
> Comment on attachment 8683225 [details] [diff] [review]
> Add support for filtering censuses to memory tool's frontend
> 
> Review of attachment 8683225 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> If there's an easy way to do a mochitest for this as well, let's do it or
> file a follow up

Did it in this push.

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c3140db8deba

Comment 8

[Will Bamberg [:wbamberg]]

I've added a short note on this: https://developer.mozilla.org/en-US/docs/Tools/Memory#Analyzing_a_snapshot. Not sure if we need anything more extensive?

Comment 9

[Tim Nguyen :ntim]

Release Note Request (optional, but appreciated)
[Why is this notable]: new functionality for memory tool
[Suggested wording]: Ability to filter snapshot output in memory tool
[Links (documentation, blog post, etc)]:

Comment 10

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

(In reply to Will Bamberg [:wbamberg] from comment #8)
> I've added a short note on this:
> https://developer.mozilla.org/en-US/docs/Tools/Memory#Analyzing_a_snapshot.
> Not sure if we need anything more extensive?

I think this feature is necessary for good usability, but I agree that it is difficult to find a compelling example for documentation. One example might be searching for your CDN's hostname to see all the structures in memory that were created by third party libraries (when combined with allocation stack recording). A similar workflow is employed by the L20N.js developers whose script is designed to be embedded in other people's apps. They don't care about overall memory consumption on the page, just the bits related to their code, so they record allocation stacks and then filter for "L20N.js" to show only the things allocated with their script on the stack.

Comment 11

[Sylvestre Ledru [:Sylvestre]]

Added to the release notes with Tim's wording (thanks!)