1221692 - Clean up references to playPreview and prevent content generation at runtime in pluginProblem.xml and PluginContent.jsm

Status: RESOLVED DUPLICATE of bug 1192831

(Core :: XBL, defect)

Description

[Cody Crews]

Attachment: removePlayPreviewContentGeneration.patch

Followup work from bug 1045034.  With bug 1220901 already taking care of other concerns this should have everything handled.

Comment 1

[Cody Crews]

Comment on attachment 8683248 [details] [diff] [review]
removePlayPreviewContentGeneration.patch

Review of attachment 8683248 [details] [diff] [review]:
-----------------------------------------------------------------

This patch is part 1 of a set of changes being done for multiple issues found in bug 1045034.  Here we clean up remaining references to playPreview, and stop runtime content generation which caused some interesting issues.

Comment 2

[Bobby Holley (:bholley)]

Hang on - is your tree up to date cody? It looks like this was already removed in bug 1192831...

Comment 3

[Cody Crews]

I noticed the div for previewing content was already gone in the newer nightly builds.  I didn't even use bundles for this, just the raw source and hg init, hg add etc.

Wow I just looked over those bugs.  I even asked yesterday how long until the work on jsplugins makes this pointless.  It's all good though, we can mark this a dup of that work or something.  The change protecting native anonymous subtrees and bindings with chromeOnlyContent is going to be the real gain here.

Comment 4

[Cody Crews]

Sorry this is my fault, I knew playPreview stuff was being taken out.  To even pinpoint that it was the runtime generation of that iframe element I had to use older releases that still had playPreview there.

There's still enough gain from this for me to be happy with some wasted work, for once I feel like I'm actually gaining ground on the source because of how fast it moves.

I'll be back on nightly builds from now on.

Comment 5

[Daniel Veditz [:dveditz]]

given comment 2 can this bug be resolved "worksforme" or is there remaining work here?

Comment 6

[Bobby Holley (:bholley)]

Comment on attachment 8683248 [details] [diff] [review]
removePlayPreviewContentGeneration.patch

Review of attachment 8683248 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/modules/PluginContent.jsm
@@ -307,5 @@
>        case Ci.nsIObjectLoadingContent.PLUGIN_VULNERABLE_UPDATABLE:
>          return "PluginVulnerableUpdatable";
>        case Ci.nsIObjectLoadingContent.PLUGIN_VULNERABLE_NO_UPDATE:
>          return "PluginVulnerableNoUpdate";
> -      case Ci.nsIObjectLoadingContent.PLUGIN_PLAY_PREVIEW:

Can you remove this from nsIObjectLoadingContent as well?

Comment 7

[Bobby Holley (:bholley)]

(In reply to Bobby Holley (busy) from comment #6)
> Can you remove this from nsIObjectLoadingContent as well?

Whoops, that was just a saved review comment before I realized this already happened. Ignore it.

Comment 8

[Cody Crews]

Bobby I cc'ed you over on bug 1220901.  I realized there was hardly anyone on the cc list and im looking for input on locking down any alterations to native anonymous subtrees at runtime.