1221696 - Review cancelled instead of review-

Status: RESOLVED DUPLICATE of bug 1197879

(bugzilla.mozilla.org Graveyard :: Extensions: MozReview Integration, defect)

Description

[Benjamin Smedberg]

I did a review on https://reviewboard.mozilla.org/r/24157/ which should have been the equivalent of review-. But in bugzilla bug 1220223, it didn't mark r- it cancelled the review flag altogether. That's not good because there was another reviewer who marked r+ and it looked like the patch was ready to land.

Comment 1

[Mark Côté [:mcote]]

Hmm that's an interesting point.  We made the decision to do review cancel instead of r- because that seems like how many people started reviewing GitHub pull requests in BMO.  Several people have also made the argument that cancelled reviews are more polite, and hence more welcoming to new contributors, than r-s.  It is true, however, that that leaves us in the position of having no clear way (aside from comments) to override, or at least counter, someone else's r+.  Will need to think on this.