Closed Bug 1221874 Opened 4 years ago Closed 4 years ago

"ASSERTION: writing-mode mismatch" when changing text-orientation to "sideways"

Categories

(Core :: Layout: Text and Fonts, defect)

Product:
Core
Component:
Layout: Text and Fonts
Type:
defect
Priority:
Not set

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla45
Tracking Flags:
Tracking Status
firefox45 --- fixed

People

(Reporter: jruderman, Assigned: jfkthame)

References

(Blocks 1 open bug)

Details

(Keywords: assertion, testcase)

Attachments

(4 files)

testcase
288 bytes, text/html
Details
stack
15.78 KB, text/plain
Details
crashtest (currently asserts)
1.57 KB, patch
smontagu
: review+
Details | Diff | Splinter Review
Ignore the sideways-orientation flag when logical-coordinate classes are checking writing-mode compatibility
3.30 KB, patch
smontagu
: review+
Details | Diff | Splinter Review
Attached file testcase — 
###!!! ASSERTION: writing-mode mismatch: 'aWritingMode == GetWritingMode()', file WritingModes.h, line 957

(lldb) p/x aWritingMode
(mozilla::WritingMode) $1 = (mWritingMode = 0x21)

(lldb) p/x GetWritingMode()
(mozilla::WritingMode) $2 = (mWritingMode = 0x01)

Seems like they differ by eSidewaysMask:
https://dxr.mozilla.org/mozilla-central/source/layout/generic/WritingModes.h#613
Attached file stack — 
Ah, yes.... the check here is being a bit too fussy; we should ignore the eSidewaysMask bit, because it doesn't affect the compatibility of logical coordinates.
Jesse's testcase as a crashtest; currently asserts with trunk code.
Attachment #8683617 - Flags: review?(smontagu)
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Attachment #8683617 - Flags: review?(smontagu) → review+
Attachment #8683618 - Flags: review?(smontagu) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/a00a4faead69df2a87111318c83f9d774459c467
Bug 1221874 - Crashtest for overzealous writing-mode check (currently asserts). r=smontagu

https://hg.mozilla.org/integration/mozilla-inbound/rev/13dd11b7a0f8bc8dded14a39140c740d7f81f491
Bug 1221874 - Ignore the sideways-orientation flag when logical-coordinate classes are checking writing-mode compatibility. r=smontagu
https://hg.mozilla.org/mozilla-central/rev/a00a4faead69
https://hg.mozilla.org/mozilla-central/rev/13dd11b7a0f8
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox45: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.