1221874 - "ASSERTION: writing-mode mismatch" when changing text-orientation to "sideways"

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[Jesse Ruderman]

Attachment: testcase

###!!! ASSERTION: writing-mode mismatch: 'aWritingMode == GetWritingMode()', file WritingModes.h, line 957

(lldb) p/x aWritingMode
(mozilla::WritingMode) $1 = (mWritingMode = 0x21)

(lldb) p/x GetWritingMode()
(mozilla::WritingMode) $2 = (mWritingMode = 0x01)

Seems like they differ by eSidewaysMask:
https://dxr.mozilla.org/mozilla-central/source/layout/generic/WritingModes.h#613

Comment 1

[Jesse Ruderman]

Attachment: stack

Comment 2

[Jonathan Kew (:jfkthame)]

Ah, yes.... the check here is being a bit too fussy; we should ignore the eSidewaysMask bit, because it doesn't affect the compatibility of logical coordinates.

Comment 3

[Jonathan Kew (:jfkthame)]

Attachment: crashtest (currently asserts)

Jesse's testcase as a crashtest; currently asserts with trunk code.

Comment 4

[Jonathan Kew (:jfkthame)]

Attachment: Ignore the sideways-orientation flag when logical-coordinate classes are checking writing-mode compatibility

And this fixes things.

Comment 5

[Jonathan Kew (:jfkthame)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a00a4faead69df2a87111318c83f9d774459c467
Bug 1221874 - Crashtest for overzealous writing-mode check (currently asserts). r=smontagu

https://hg.mozilla.org/integration/mozilla-inbound/rev/13dd11b7a0f8bc8dded14a39140c740d7f81f491
Bug 1221874 - Ignore the sideways-orientation flag when logical-coordinate classes are checking writing-mode compatibility. r=smontagu

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a00a4faead69
https://hg.mozilla.org/mozilla-central/rev/13dd11b7a0f8