Closed Bug 1221876 Opened 9 years ago Closed 8 years ago

Intermittent root_settings_test.js | check root panel settings common tests airplane mode enable airplane mode

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Settings
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(feature-b2g:2.6+)

Status:
RESOLVED FIXED
Project Flags:
feature-b2g 2.6+

People

(Reporter: nigelb, Assigned: gasolin)

References

(
URL
)

Details

(Keywords: intermittent-failure, Whiteboard: [MJS] [intermittents])

Attachments

(3 files)

[gaia] gasolin:issue-1221876 > mozilla-b2g:master
46 bytes, text/x-github-pull-request
yzen
: review+
Details | Review
[gaia] mikehenrty:bug-1221876-disable-root-settings-test > mozilla-b2g:master
46 bytes, text/x-github-pull-request
gasolin
: review+
Details | Review
[gaia] gasolin:issue-1221876-2 > mozilla-b2g:master
46 bytes, text/x-github-pull-request
Details | Review 
https://treeherder.mozilla.org/logviewer.html#?job_id=16830181&repo=mozilla-inbound

 04:04:12     INFO -  TEST-END | apps/settings/test/marionette/tests/notifications_settings_test.js | manipulate notifications settings disable Show on lockscreen took 498 ms

 04:09:08     INFO -  ..............................[marionette-mocha]   1 failing

 04:09:08     INFO -  [marionette-mocha]

 04:09:08     INFO -  [marionette-mocha]   1) check root panel settings common tests airplane mode enable airplane mode:

 04:09:08     INFO -    Error: timeout exceeded!

 04:09:08     INFO -        at Object.Client.waitForSync (/home/worker/gaia/node_modules/marionette-client/lib/marionette/client.js:756:16)

 04:09:08     INFO -        at Object.Client.waitFor (/home/worker/gaia/node_modules/marionette-client/lib/marionette/client.js:722:60)

 04:09:08     INFO -        at Object.RootPanel.airplaneMode (/home/worker/gaia/apps/settings/test/marionette/app/regions/root.js:50:17)

 04:09:08     INFO -        at Context.<anonymous> (/home/worker/gaia/apps/settings/test/marionette/tests/root_settings_test.js:89:19)

 04:09:08     INFO -        at callFn (/home/worker/gaia/node_modules/mocha/lib/runnable.js:223:21)

 04:09:08     INFO -        at Test.Runnable.run (/home/worker/gaia/node_modules/mocha/lib/runnable.js:216:7)

 04:09:08     INFO -        at Test.MarionetteTest.run (/home/worker/gaia/node_modules/marionette-js-runner/lib/ui.js:25:31)

 04:09:08     INFO -        at Runner.runTest (/home/worker/gaia/node_modules/mocha/lib/runner.js:373:10)

 04:09:08     INFO -        at /home/worker/gaia/node_modules/mocha/lib/runner.js:451:12

 04:09:08     INFO -        at next (/home/worker/gaia/node_modules/mocha/lib/runner.js:298:14)

 04:09:08     INFO -        at /home/worker/gaia/node_modules/mocha/lib/runner.js:308:7

 04:09:08     INFO -        at next (/home/worker/gaia/node_modules/mocha/lib/runner.js:246:23)

 04:09:08     INFO -        at Object._onImmediate (/home/worker/gaia/node_modules/mocha/lib/runner.js:275:5)

 04:09:08     INFO -        at processImmediate [as _immediateCallback] (timers.js:354:15)

 04:09:08     INFO -  [marionette-mocha]

 04:09:08     INFO -  .

 04:09:08     INFO -  /home/worker/gaia/apps/settings/test/marionette/tests/root_settings_test.js failed. Will retry.
I think this is related to the changes made in bug 1220046. Can you take a look?
Flags: needinfo?(gasolin)
Ya... now we need more time to wait until wifi panel is ready
BTW, The default wifi status is changed to `Not connected` instead of `Disabled`
Flags: needinfo?(gasolin)
I found wifi description does not respond in mulet, and new airplane mode enable/disable state is count on it.

Nigel could you help point me about the right command to run integration test on device?



The command
```
BUILDAPP=device make test-integration
```
does not bring test on device

And 

```
TEST_FILES="/<absolute gaia path>/apps/settings/test/marionette/tests/airplane_mode_settings_test.js" npm run marionette
```

also test on mulet.
Flags: needinfo?(nigelbabu)
We will need this test fixed if we want to unhide the intermittent failures on Treeherder. Let me know if I can be of assistance here.
Blocks: 1222215
Fred, do you still need help running this on a device? I imagine people like Eli or Gareth could help you out there. In the meantime, is there anything blocking fixing this test that I can help out with?
Flags: needinfo?(gasolin)
I have no luck to run this on a device yet, will try again tomorrow.

Another issue I found in Comment 6 is the wifi status cannot update on mulet (might due to lack of wifi api mock).
Flags: needinfo?(gasolin)
Comment on attachment 8687888 [details] [review]
[gaia] mikehenrty:bug-1221876-disable-root-settings-test > mozilla-b2g:master

Fred, since you are working on a fix for this test already, and since for the time being this test is not provided us with too much protection based on the changes you are making, can we disable this test so we can move forward with bug 1222215 this week? I figure you can just remove this line in the patch you've already submitted.
Attachment #8687888 - Flags: review?(gasolin)
Attachment #8687888 - Flags: review?(gasolin) → review+
My patch has addressed issue in comment 5, if you known someone is able to test it on device, please reach him for help.
feature-b2g: --- → 2.6+
Whiteboard: [MJS]
Fred could you find someone to work on this?
Flags: needinfo?(gasolin)
Now I can reproduce on device with new ROM.
The updated patch shows all green on treeherder
Assignee: nobody → gasolin
Flags: needinfo?(gasolin)
Comment on attachment 8684773 [details] [review]
[gaia] gasolin:issue-1221876 > mozilla-b2g:master

Yura, could you help review it?
Attachment #8684773 - Flags: review?(yzenevich)
Comment on attachment 8684773 [details] [review]
[gaia] gasolin:issue-1221876 > mozilla-b2g:master

Thanks, looks good and test passes.
Attachment #8684773 - Flags: review?(yzenevich) → review+
merged the first commit in mozlando lol
https://github.com/mozilla-b2g/gaia/commit/76e076a4d013b39016891aae6cdc4886a29e1486

Thanks for review!
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Backed out for bustage on Gij(15) on B2G Desktop and Mulet

Link for failure: https://treeherder.mozilla.org/logviewer.html#?job_id=3524218&repo=b2g-inbound

Revert: https://github.com/mozilla-b2g/gaia/commit/6b430ea7274af4c352de16b75e6bb85d7621ca83
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Since this test is disabled, I'm unblocking it from bug 1222215.
No longer blocks: 1222215
* comment out intermittent cases and will fix in following bug
* re-enable gij test for the rest of test cases.

merged https://github.com/mozilla-b2g/gaia/commit/a85b8648d5b5fb831d3379387a5be282a6677dff
Status: REOPENED → RESOLVED
Closed: 9 years ago → 8 years ago
Resolution: --- → FIXED
Whiteboard: [MJS] → [MJS] [intermittents]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: