Open Bug 1221879 Opened 8 years ago Updated 1 year ago

races with ReverbInputBuffer::m_writeIndex from ReverbConvolver

Categories

(Core :: Web Audio, defect, P3)

Product:
Core
Component:
Web Audio
Version:
24 Branch
Type:
defect

Tracking

()

People

(Reporter: karlt, Unassigned)

References

(Depends on 1 open bug)

Details

ReverbInputBuffer::m_writeIndex is read and written on different threads with locks on neither.  It could be atomic, but probably better to have a separate multi-thread variable to replace m_moreInputBuffered accessed within m_backgroundThreadLock because that lock will be used anyway.

Similarly setting m_moreInputBuffered = false after processing and outside of
the lock looks unhelpful, forcing a wait even if more has been buffered.
Mass change P2->P3 to align with new Mozilla triage process.
Priority: P2 → P3
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.