races with ReverbInputBuffer::m_writeIndex from ReverbConvolver

NEW
Unassigned

Status

()

P3
normal
3 years ago
a year ago

People

(Reporter: karlt, Unassigned)

Tracking

(Depends on: 1 bug)

24 Branch
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

ReverbInputBuffer::m_writeIndex is read and written on different threads with locks on neither.  It could be atomic, but probably better to have a separate multi-thread variable to replace m_moreInputBuffered accessed within m_backgroundThreadLock because that lock will be used anyway.

Similarly setting m_moreInputBuffered = false after processing and outside of
the lock looks unhelpful, forcing a wait even if more has been buffered.
Mass change P2->P3 to align with new Mozilla triage process.
Priority: P2 → P3
You need to log in before you can comment on or make changes to this bug.