1221898 - Followup of bug 1211769: Fix PBAP memory leakage

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Follow up:
https://bugzilla.mozilla.org/show_bug.cgi?id=1211769#c38

https://dxr.mozilla.org/mozilla-central/source/dom/bluetooth/bluedroid/BluetoothPbapManager.cpp?from=bluetoothpbapmanager.cpp#928

      // ----  Part 2b: [headerId:1][length:2][Body:var] ---- //
      index += AppendHeaderBody(&res[index],
                                remainingPacketSize,
                                (uint8_t*) buf.forget(),
                                numRead);

Passing (uint8_t*)buf.forget() can cause memory leakage.

Comment 1

[Ben Tian (inactive)]

Attachment: Patch 1 (v1): Fix PBAP memory leakage

Comment 2

[Ben Tian (inactive)]

Attachment: Patch 1 (v2): Fix PBAP memory leakage

Comment 3

[Ben Tian (inactive)]

Set 2.2r blocker for PBAP memory leakage.

Comment 4

[Bruce Sun [:brsun]]

Comment on attachment 8683562 [details] [diff] [review]
Patch 1 (v2): Fix PBAP memory leakage

Review of attachment 8683562 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/6cf483eb34a6

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6cf483eb34a6

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g37_v2_2r/rev/75596315708f