1221915 - [RTL][System]Status bar can't show signal icons.

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::System::Status bar, Utility tray, Notification, defect, P1)

Description

[Jenny (Leave from Mozilla)]

Attachment: signal icons_v2.5&master.png

[1.Description]:
[RTL][Contacts][Flame kk_v2.5&v2.6]Set your phone language to Arabic, tap status bar and observe, signal icons can't be showed.
See attachment: signal icons_v2.5&master.png.

[2.Testing Steps]: 
 Premise: One or two SIM cards inserted to device.
1. Set your phone language to Arabic.
2. Observe the status bar.

[3.Expected Result]: 
In step 2, The status bar can show signal icons.

[4.Actual Result]: 
In step 2, The status bar can't show signal icons.

[5.Reproduction build]: 
Device: Flame KK v2.5 512mb(Affected)
Build ID               20151104004502
Gaia Revision          91cac94948094cfdcd00cba5c6483e27e80cb3b0
Gaia Date              2015-10-28 20:32:15
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/f14715d84261aa5da68680bc889734f923d5d4c7
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151104.041400
Firmware Date          Wed Nov  4 04:14:13 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Flame KK v2.6 512mb (master)(Affected)
Build ID               20151104150239
Gaia Revision          47da49f8206788d70d834c3a63d9245d50c89103
Gaia Date              2015-11-03 21:48:23
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/6077f51254c69a1e14e1b61acba4af451bf1783e
Gecko Version          45.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151104.182640
Firmware Date          Wed Nov  4 18:26:52 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.6 (master) (Unaffected)
Build ID               20151105105137
Gaia Revision          e68d693cb55fb5d8946498eb2bdb63f55116d38e
Gaia Date              2015-11-05 01:05:27
Gecko Revision         n/a
Gecko Version          45.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.rose.20151103.153542
Firmware Date          Tue Nov 15:36:03 CST 2015
Bootloader             s1
[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
Free test

Comment 1

[Sam Foster [:sfoster] (he/him)]

RTL triage: we've not been able to reproduce this, can we get more details and confirm this?

Comment 2

[Pi Wei Cheng [:piwei] (inactive)]

This issue seems to only reproduce when using dual SIMs and one of them needs to be a roaming SIM (a SIM that will show a globe icon next to the signal icon, like shown in attachment 8683560 [details]). I wasn't able to reproduce it using regular SIMs, and I wasn't able to reproduce it with roaming SIM by itself on either of the SIM slots.

Tested on:
Device: Flame 2.6 Master
BuildID: 20151105030203
Gaia: 607b9c5db7fdbbafc16a572e7c319baa266a3372
Gecko: 59c648a3f95524cb1ee42f2306c1db2698d35258
Gonk: 205ac4204bbbb2098a8046444acba551ba5dc75a
Version: 45.0a1 (2.6) 
Firmware Version: v18Dv4
User Agent: Mozilla/5.0 (Mobile; rv:45.0) Gecko/45.0 Firefox/45.0

Comment 3

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Sam please see comment 2.

Comment 4

[Sam Foster [:sfoster] (he/him)]

Any ideas :mhenretty? I don't have the SIMs necessary to repro this, I'm also not sure how RTL plays into it. I think pseudo-locale should be adequate to test, but building with Arabic would eliminate doubt.

Comment 5

[Michael Henretty [:mikehenrty][:mhenretty]]

Attachment: [screenshot] utility tray RTL problem

I'm not able to reproduce, but on my Aries device I am seeing something much worse.

Alberto, can you take a look?

Comment 6

[Alberto Pastor [:albertopq]]

We are currently calculating the number of icons needed for start using the maximized class. This tries to avoid reflows when we are sure that the icons are not bigger than the minimized width. Apparently this calculation is wrong for the dual SIM use case (given the icons width), so I have an idea of what's going on. 

Michael, could you please file a new bug for the RTL one? Thanks!

Comment 7

[Michael Henretty [:mikehenrty][:mhenretty]]

(In reply to Alberto Pastor [:albertopq] from comment #6)
> Michael, could you please file a new bug for the RTL one? Thanks!

Done. Bug 1222396.

Comment 8

[Alberto Pastor [:albertopq]]

The problem here is that the 'Time' icon takes more space in that language, and the 'mobile-connection' is taken as 1 only icon, composed by all the SIMs icons. We need to split those into different icons to, at least, see 1 one of them

Comment 9

[pelloux]

(In reply to Alberto Pastor [:albertopq] from comment #8)
> The problem here is that the 'Time' icon takes more space in that language

I believe https://bugzilla.mozilla.org/show_bug.cgi?id=1215068 will solve that (until it lands Arabic locale always display AM/PM indicator)

Comment 10

[Alberto Pastor [:albertopq]]

That's cool! I still think we need to split the signal icons into 1 per slot (that way we can show 1 without hiding the other) but I'll create a separate bug for that then.

Thanks!

Comment 11

[Zibi Braniecki [:zbraniecki][:gandalf]]

> I believe https://bugzilla.mozilla.org/show_bug.cgi?id=1215068 will solve that (until it lands Arabic locale always display AM/PM indicator)

I'm not sure about that. Time icon is localized which means that it may take different amount of space than in en-US and our code should handle that. Here it seems that it doesn't.

Comment 12

[Alberto Pastor [:albertopq]]

Not working on this at the moment. Will try to take it back when possible.

Comment 13

[Zibi Braniecki [:zbraniecki][:gandalf]]

This should be working now on master. Can someone verify that pls?

Comment 14

[Zibi Braniecki [:zbraniecki][:gandalf]]

Yeah, it works on all tested locales, but I'm not sure if we should close this bug. The status bar algo should allow for time to take more space without breaking.