Closed Bug 1221924 Opened 9 years ago Closed 9 years ago

[TV] FxOS TV Metrics - Treat the smart-home as an overlay instead of an app

Categories

(Firefox OS Graveyard :: Gaia::TV::System, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::TV::System
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:2.5+, feature-b2g:2.5+, b2g-v2.5 fixed, b2g-master fixed)

Status:
RESOLVED FIXED
Project Flags:
blocking-b2g 2.5+
feature-b2g 2.5+
Tracking Flags:
Tracking Status
b2g-v2.5 --- fixed
b2g-master --- fixed

People

(Reporter: lchang, Assigned: rexboy)

References

Details

(Whiteboard: [ft:conndevices][partner-blocker][partner-cherry-pick])

Attachments

(1 file)

[gaia] rexboy7:1221924-metrics-smart-home-as-overlay > mozilla-b2g:master
46 bytes, text/x-github-pull-request
lchang
: review+
jocheng
: approval-gaia-v2.5+
Details | Review 
Since the homescreen on TV is actually an overlay, what we are going to do here is

1. don't change the "currentApp" status since it's still visible under homescreen.
2. subtract the time spent on the homescreen from the data of current app.
3. record the data of homescreen separately.
feature-b2g: --- → 2.5+
Whiteboard: [ft:conndevices][partner-blocker][partner-cherry-pick]
Assignee: nobody → rexboy
Comment on attachment 8689433 [details] [review]
[gaia] rexboy7:1221924-metrics-smart-home-as-overlay > mozilla-b2g:master

1st commit.
I checked the intention of the bug with Josh but not quite sure if this patch matches the requested behavior. Luke can you help review it?
Attachment #8689433 - Flags: review?(lchang)
Status: NEW → ASSIGNED
Comment on attachment 8689433 [details] [review]
[gaia] rexboy7:1221924-metrics-smart-home-as-overlay > mozilla-b2g:master

R+ with a few comments. In general, please add some comments to describe the purpose of new stuff.
Attachment #8689433 - Flags: review?(lchang) → review+
master
https://github.com/mozilla-b2g/gaia/commit/2e5f63b23afc39d0574ef27806a77da7885bff0c
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment on attachment 8689433 [details] [review]
[gaia] rexboy7:1221924-metrics-smart-home-as-overlay > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): feature
[User impact] if declined: Mozilla gets usage data that are not recorded as expected rule on TV.
[Testing completed]: 
[Risk to taking this patch] (and alternatives if risky): small
[String changes made]: none
Attachment #8689433 - Flags: approval-gaia-v2.5?
blocking-b2g: --- → 2.5+
status-b2g-v2.5: --- → affected
status-b2g-master: --- → fixed
Comment on attachment 8689433 [details] [review]
[gaia] rexboy7:1221924-metrics-smart-home-as-overlay > mozilla-b2g:master

Approve as required for Metrics on TV 2.5
Attachment #8689433 - Flags: approval-gaia-v2.5? → approval-gaia-v2.5+
Sorry, we should backout first, it breaks the unit tests.
Keywords: checkin-needed
or so it seems ?
Keywords: checkin-needed
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: