Build: Beta 1113 iPad Air 2 (9.1) Stop button ([X]) reloads the page instead of stop loading it Note: Not reproducible on iPhone 6 Plus (iOS 9.1)
Summary: 'Stop' button reloads the page → 'Stop' button reloads the page on iPad devices
Summary: 'Stop' button reloads the page on iPad devices → Stop button reloads the page on iPad devices
Created attachment 8683982 [details] [review] PR: https://github.com/mozilla/firefox-ios/pull/1226 This patch transfers the `isLoading` state to the `BrowserToolbarHelper`, which is the component that deals with presses on the Stop/Reload button. Without the state transferred, it always thinks it needs to reload the page.
Attachment #8683982 - Flags: review?(rnewman)
A good page to test this on is http://deelay.me - it loads some images incrementally, delayed, so you have plenty of time to interrupt the page load.
Comment on attachment 8683982 [details] [review] PR: https://github.com/mozilla/firefox-ios/pull/1226 LGTM. (And by G I mean B.)
Attachment #8683982 - Flags: review?(rnewman) → review+
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Verifying as fixed on Beta 1202
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.