Stop button reloads the page on iPad devices

VERIFIED FIXED

Status

()

Firefox for iOS
Browser
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: csuciu, Assigned: st3fan)

Tracking

({reproducible})

unspecified
All
iOS
reproducible

Firefox Tracking Flags

(fxios-v1.1 affected, fxios1.2+)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
Build: Beta 1113
iPad Air 2 (9.1)

Stop button ([X]) reloads the page instead of stop loading it

Note: Not reproducible on iPhone 6 Plus (iOS 9.1)
Silly. Reproducible.
Keywords: reproducible
Summary: 'Stop' button reloads the page → 'Stop' button reloads the page on iPad devices
(Assignee)

Updated

3 years ago
tracking-fxios: ? → 1.2+
(Assignee)

Updated

3 years ago
Summary: 'Stop' button reloads the page on iPad devices → Stop button reloads the page on iPad devices
(Assignee)

Comment 2

3 years ago
Created attachment 8683982 [details] [review]
PR: https://github.com/mozilla/firefox-ios/pull/1226

This patch transfers the `isLoading` state to the `BrowserToolbarHelper`, which is the component that deals with presses on the Stop/Reload button. Without the state transferred, it always thinks it needs to reload the page.
Attachment #8683982 - Flags: review?(rnewman)
(Assignee)

Comment 3

3 years ago
A good page to test this on is http://deelay.me - it loads some images incrementally, delayed, so you have plenty of time to interrupt the page load.
Comment on attachment 8683982 [details] [review]
PR: https://github.com/mozilla/firefox-ios/pull/1226

LGTM. (And by G I mean B.)
Attachment #8683982 - Flags: review?(rnewman) → review+
Assignee: nobody → sarentz
Status: NEW → ASSIGNED
(Assignee)

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED

Updated

3 years ago
Flags: needinfo?(catalin.suciu)
Keywords: verifyme
(Reporter)

Comment 5

3 years ago
Verifying as fixed on Beta 1202
Status: RESOLVED → VERIFIED
Flags: needinfo?(catalin.suciu)
(Reporter)

Updated

3 years ago
Keywords: verifyme
You need to log in before you can comment on or make changes to this bug.