Improve reviewer parsing from commit summaries

RESOLVED FIXED

Status

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: dminor, Assigned: glob)

Tracking

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
We'll need to improve things when we start rewriting commits. This will also help with the work to re-request reviews using r?.
(Assignee)

Updated

3 years ago
Assignee: nobody → glob
(Assignee)

Comment 1

3 years ago
Created attachment 8684043 [details]
MozReview Request: mozautomation: Rework parse_reviewers to improve logic (Bug 1221999); r?gps

mozautomation: Rework parse_reviewers to improve logic (Bug 1221999); r?gps

Rewrite the reviewer parsing code so it handles unusual syntax.  Matching
reviewers in a single regex makes it trivial to perform operations such as
replacing matched reviewers.
Attachment #8684043 - Flags: review?(gps)
(Assignee)

Comment 2

3 years ago
Comment on attachment 8684043 [details]
MozReview Request: mozautomation: Rework parse_reviewers to improve logic (Bug 1221999); r?gps

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/24483/diff/1-2/

Comment 4

3 years ago
Comment on attachment 8684043 [details]
MozReview Request: mozautomation: Rework parse_reviewers to improve logic (Bug 1221999); r?gps

https://reviewboard.mozilla.org/r/24483/#review22111

I would have been terrified to review this if the test coverage weren't so good.

You can always count on a Perl guru being able to solve complicated parsing problems like this with regular expressions :D. Nice work.
Attachment #8684043 - Flags: review?(gps) → review+

Updated

3 years ago
Duplicate of this bug: 1182143

Updated

3 years ago
Duplicate of this bug: 1171984

Updated

3 years ago
Duplicate of this bug: 1191742

Updated

3 years ago
Duplicate of this bug: 1194349

Updated

3 years ago
Duplicate of this bug: 1220669
(Assignee)

Comment 10

3 years ago
https://hg.mozilla.org/hgcustom/version-control-tools/rev/361c7d0f6a40
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Product: Developer Services → MozReview
You need to log in before you can comment on or make changes to this bug.