1222032 - Improve copy for disambiguating login update

Status: RESOLVED FIXED

(Toolkit :: Password Manager, enhancement, P3)

Description

[Ryan Feeley [:rfeeley]]

Attachment: Screenshot 2015-11-03 13.47.51.png

When users change their password on a website, sometimes the username is not detectable, and if the user has more than one login for a site, they can select the login they would like to update.

Currently we present (screenshot attached)

* Please confirm which user you are changing the password for
* [list of usernames]
* [ OK - primary ] [ Cancel ]

I think the copy could be improved to something like:

* Select the login you are updating:
* [list of usernames]
* [ Update - primary ] [ Cancel ]

But we are open to suggestion…

Comment 1

[Matej Novak [:matej]]

(In reply to Ryan Feeley [:rfeeley] from comment #0)
> Created attachment 8683694 [details]
> Screenshot 2015-11-03 13.47.51.png
> 
> When users change their password on a website, sometimes the username is not
> detectable, and if the user has more than one login for a site, they can
> select the login they would like to update.
> 
> Currently we present (screenshot attached)
> 
> * Please confirm which user you are changing the password for
> * [list of usernames]
> * [ OK - primary ] [ Cancel ]
> 
> I think the copy could be improved to something like:
> 
> * Select the login you are updating:
> * [list of usernames]
> * [ Update - primary ] [ Cancel ]
> 
> But we are open to suggestion…

Looks good, though I think we can shorten it further:

* Select which login to update:

Or a little longer, but friendlier:

* Choose which login you'd like to update:

I'm going back and forth between "login" and "user," though. Will "login" be clear to everyone? I always worry it sounds like jargon.

Comment 2

[Ryan Feeley [:rfeeley]]

Thanks to Gemma, we have some research from February that indicates users are very comfortable with the term "login" and seem to prefer it in this context (a combination of username and password).

Her deck:
https://docs.google.com/presentation/d/17iw3ls5AN2FbbSqVdV_i_-PHp6tXbmmw5-xdA4vS5ak/edit#slide=id.g77b514185_0113

"Select which login to update:" is perfect. Easy to take in at a glance and make a quick decision, describes action accurately.

Thanks!

Comment 3

[Matej Novak [:matej]]

(In reply to Ryan Feeley [:rfeeley] from comment #2)
> Thanks to Gemma, we have some research from February that indicates users
> are very comfortable with the term "login" and seem to prefer it in this
> context (a combination of username and password).

Awesome, thanks!

Comment 4

[Ryan Feeley [:rfeeley]]

Attachment: select-login.png

One for the backlog of simple login manager changes mattn? I think I will see if bwinton's qx posse might want to tackle this tiny change.

* Select which login to update:
* [list of usernames]
* [ Update - primary ] [ Cancel ]

Comment 5

[Matthew N. [:MattN]]

LGTM

Comment 6

[Jim Porter (:squib)]

There's an identical string for mobile too. Should I just update the string in toolkit or should I change mobile as well? Here are the DXR results if they help: <https://dxr.mozilla.org/mozilla-central/search?q=userSelectText&redirect=false>.

Comment 7

[Ryan Feeley [:rfeeley]]

Great idea! I didn't know mobile had this.

Comment 8

[Jim Porter (:squib)]

Attachment: Bug 1222032 - Improve copy for disambiguating login update

Review commit: https://reviewboard.mozilla.org/r/121228/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/121228/

Comment 9

[Jim Porter (:squib)]

This patch contains both the desktop and mobile changes. If it makes sense for someone from the mobile team to look at this, just let me know!

Comment 10

[Jim Porter (:squib)]

Comment on attachment 8848305 [details]
Bug 1222032 - Improve copy for disambiguating login update

Clearing review; I just realized I forgot to change the "Ok" string to "Update".

Comment 11

[Jim Porter (:squib)]

Comment on attachment 8848305 [details]
Bug 1222032 - Improve copy for disambiguating login update

Nevermind, re-requesting review. It looks like replacing "OK" with "Update" would be pretty tough (I'd either have to reimplement my own version of nsIPromptService.select or enhance that function to accept button labels).

I can do that if you want (the latter seems like the better way), but it'd probably be best to do it in a separate bug. Maybe just as a followup to this one? I'm a big fan of descriptive button labels, so I can definitely see some value in improving nsIPromptService.

Comment 12

[Jim Porter (:squib)]

Comment on attachment 8848305 [details]
Bug 1222032 - Improve copy for disambiguating login update

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/121228/diff/1-2/

Comment 13

[Jim Porter (:squib)]

Also: are there any example sites I can try this out on? I want to make 100% sure that this actually works right, but I don't know of any sites that would trigger this.

Comment 14

[Ryan Feeley [:rfeeley]]

It's commonly triggered when you change your password as the email is not present there. Using a site you have a real account with, log in with a fake login and save it. And then change your password. Should trigger it.

Comment 15

[Matthew N. [:MattN]]

Comment on attachment 8848305 [details]
Bug 1222032 - Improve copy for disambiguating login update

https://reviewboard.mozilla.org/r/121228/#review126012

(In reply to Jim Porter (:squib) from comment #11)
> It looks like replacing "OK" with "Update"
> would be pretty tough (I'd either have to reimplement my own version of
> nsIPromptService.select or enhance that function to accept button labels).

Yeah, missing this change was the reason I didn't rubberstamp it when I first received the review… I went down the path of investigating how much work it would be since I didn't realize that the `select` API didn't support specify the button labels like one of the adjacent APIs does when I suggested this bug for you.

> I can do that if you want (the latter seems like the better way), but it'd
> probably be best to do it in a separate bug. Maybe just as a followup to
> this one? I'm a big fan of descriptive button labels, so I can definitely
> see some value in improving nsIPromptService.

Yeah, please file it as a follow-up. This is still an improvement as-is.

Comment 16

[Jim Porter (:squib)]

Filed bug 1353154 for the nsIPromptService.select issue.

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a42e01bc5c42
Improve copy for disambiguating login update r=MattN

Comment 18

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a42e01bc5c42