Closed Bug 1222034 Opened 4 years ago Closed 4 years ago

On the Link Clicker UI, when sharing tabs, the letterboxing should be grey, not black.

Categories

(Hello (Loop) :: Client, defect, P2)

defect

Tracking

(firefox45 fixed)

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: sevaan, Assigned: fcampo)

References

Details

Attachments

(2 files, 1 obsolete file)

Currently the letterbox banding is black. It should be the same grey as the join screen (#D8D8D8).
Blocks: 1209713
Rank: 20
Priority: -- → P2
Assignee: nobody → fernando.campo
Attached image Fixed-screenshot
Attachment #8685475 - Flags: ui-review?(sfranks)
Comment on attachment 8685472 [details] [diff] [review]
[LinkClicker] Letterbox should be grey when sharing tabs

Review of attachment 8685472 [details] [diff] [review]:
-----------------------------------------------------------------

From reading the comment, it looks like it would work to simply remove the background-color in both of those places, and allow the grey background behind to shine through, leaving simpler CSS.  If that's not actually true, then at least the comments need altering.  But I haven't actually verified that in DOMi, so let me know if I'm missing something...
Attachment #8685472 - Flags: review?(dmose)
You're totally right, I just went on automatic mode and change the color instead of let it go through
Attachment #8686609 - Flags: review?(dmose)
Attachment #8685472 - Attachment is obsolete: true
Comment on attachment 8685475 [details]
Fixed-screenshot

As I understand it, the current theory is that we should be asking both sevaan and pau for ui-review these days.  For something this simple, though, I expect that we should feel empowered to assume that review from one of them is enough.
Attachment #8685475 - Flags: ui-review?(sfranks)
Attachment #8685475 - Flags: ui-review?(b.pmm)
Comment on attachment 8686609 [details] [diff] [review]
[LinkClicker] Letterbox should be grey when sharing tabs

Looks good; r=dmose
Attachment #8686609 - Flags: review?(dmose) → review+
Attachment #8685475 - Flags: ui-review?(b.pmm) → ui-review+
(In reply to Dan Mosedale (:dmose) - use needinfo flag for response from comment #5)
> Comment on attachment 8685475 [details]
> Fixed-screenshot
> 
> As I understand it, the current theory is that we should be asking both
> sevaan and pau for ui-review these days. 
I just didn't include sevaan cause he's off this week :)
> For something this simple, though, I expect that we should feel empowered 
> to assume that review from one of them is enough.
I understood that one r+ is always enough, putting more than one reviewer was more for the sake of speed (the first to answer takes the bug from then on).

Anyways, thanks for the review, Adding check-in needed to merge
Keywords: checkin-needed
Comment on attachment 8685475 [details]
Fixed-screenshot

Dropping the old ui-r as one's enough.
Attachment #8685475 - Flags: ui-review?(sfranks)
https://hg.mozilla.org/mozilla-central/rev/b51eb1ccc07a
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.