Closed Bug 1222122 Opened 9 years ago Closed 9 years ago

[Gecko] Reconfiguring camera with a new picture size does nothing

Categories

(Firefox OS Graveyard :: Gaia::Camera, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Camera
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox45 fixed)

Status:
RESOLVED FIXED
Milestone:
FxOS-S11 (13Nov)
Tracking Flags:
Tracking Status
firefox45 --- fixed

People

(Reporter: aosmond, Assigned: aosmond)

Details

Attachments

(1 file)

bug1222122.patch, v1
5.01 KB, patch
dhylands
: review+
Details | Diff | Splinter Review 
When reconfiguring the camera (CameraControl.setConfiguration), if the only variable which has changed is the picture size, then the camera does not reconfigure as it believes nothing has changed. This is because GonkCameraControl::ValidateConfiguration does not actually verify the picture size.
Assignee: nobody → aosmond
Status: NEW → ASSIGNED
Attachment #8683848 - Flags: review?(dhylands) → review+
Flags: in-testsuite+
https://hg.mozilla.org/mozilla-central/rev/542763d3a90d
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S11 (13Nov)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: