1222145 - Cannot play 8k youtube video

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P2)

Description

[Ralph Giles (:rillian)]

Firefox fails to play 8k video from youtube:

1. https://www.youtube.com/watch?v=VaHSocnkSy4
2. Select '8k' quality from the gear popup or fullscreen on a large monitor with a fast network connection.
3. Youtube shows 'tv noise' and "An error occurred. Please try again later."

Console says: Media resource mediasource:https://www.youtube.com/3387eab3-2666-4b79-8adc-09b928d9cddb could not be decoded.

Comment 1

[Ralph Giles (:rillian)]

Possibly we just need to bump the allowed video frame size.

Comment 2

[Ralph Giles (:rillian)]

Yep. [Child 625] WARNING: Invalid plane size: file /home/giles/mozilla/firefox/dom/media/MediaData.cpp, line 280
[Child 625] WARNING: image allocation error.: file /home/giles/mozilla/firefox/dom/media/platforms/ffmpeg/FFmpegH264Decoder.cpp, line 241
-784337152[7fa3dbc69d60]: Decoder=7fa39fc3ec60 Change machine state from SEEKING to ERROR
[Child 625] WARNING: Decoder=7fa39fc3ec60 Decode error, changed state to ERROR: file /home/giles/mozilla/firefox/dom/media/MediaDecoderStateMachine.cpp, line 1905

I also see many: 

[Child 391] WARNING: We can't support non-premultiplied alpha for video!: '(aSurfaceFlags & SFE_PREFER_NO_PREMULTIPLY_ALPHA) == 0', file /home/giles/mozilla/firefox/layout/base/nsLayoutUtils.cpp, line 7000

Perhaps from failed error handling.

At least they give me Opus audio. :)

Comment 3

[Ralph Giles (:rillian)]

Attachment: Bump maximum video size to accept 8k.

This may find some bugs in our software fallback paths, but there's only one way to find out.

Comment 4

[Jean-Yves Avenard [:jya]]

Comment on attachment 8683875 [details] [diff] [review]
Bump maximum video size to accept 8k.

Review of attachment 8683875 [details] [diff] [review]:
-----------------------------------------------------------------

Do we even need a limit anyway?

IMHO this should be set by the various PDMs instead as it depends on the platform

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6c6d04b021dd

Comment 6

[Ralph Giles (:rillian)]

(In reply to Jean-Yves Avenard [:jya] from comment #4)

> Do we even need a limit anyway?

Limits are any easy way to reject malicious files trying to OOM firefox with gigapixel video zip-bombs.

> IMHO this should be set by the various PDMs instead as it depends on the
> platform

Ideally we support the same profiles everywhere. Where a particular platform isn't capable of some resolution we should fall back to software or fail independently of this check, no?

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6c6d04b021dd