Closed Bug 1222146 Opened 4 years ago Closed 4 years ago

make functional test able to run on a port specified by an environment variable

Categories

(Hello (Loop) :: Client, defect)

defect
Not set

Tracking

(firefox45 fixed)

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: dmose, Assigned: dmose)

Details

Attachments

(1 file)

No description provided.
Attachment #8683821 - Flags: review?(edilee) → review+
We already have LOOP_SERVER_URL, do we really need a seperate port setting as well (note I thjnk the url will take president over the port setting if configured like this)

Xref http://mxr.mozilla.org/mozilla-central/source/browser/components/loop/test/functional/serversetup.py#34
https://hg.mozilla.org/integration/fx-team/rev/d3e4ad7074009f1361a26369c677d2a7242f32f8
Bug 1222146-Allow test API server to be run on env-specified port, r=Mardak, NPOTB, DONTBUILD
(In reply to Mark Banner (:standard8) from comment #2)
> We already have LOOP_SERVER_URL, do we really need a seperate port setting
> as well (note I thjnk the url will take president over the port setting if
> configured like this)
> 
> Xref
> http://mxr.mozilla.org/mozilla-central/source/browser/components/loop/test/
> functional/serversetup.py#34

It won't, because that doesn't get imported from the environment either; it's set in config.py.
I don't think importing that from the environment is a good idea, though, because I (and I presume) others keep it set by default in the environment for the development copy of the server.  Things are somewhat tangled here, and could be made cleaner, but given our environment shift, I'm not sure now is the right moment to do that.
https://hg.mozilla.org/mozilla-central/rev/d3e4ad707400
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.