1222146 - make functional test able to run on a port specified by an environment variable

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect)

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: Allow test API server to be run on env-specified port

Comment 2

[Mark Banner (:standard8)]

We already have LOOP_SERVER_URL, do we really need a seperate port setting as well (note I thjnk the url will take president over the port setting if configured like this)

Xref http://mxr.mozilla.org/mozilla-central/source/browser/components/loop/test/functional/serversetup.py#34

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

https://hg.mozilla.org/integration/fx-team/rev/d3e4ad7074009f1361a26369c677d2a7242f32f8
Bug 1222146-Allow test API server to be run on env-specified port, r=Mardak, NPOTB, DONTBUILD

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

(In reply to Mark Banner (:standard8) from comment #2)
> We already have LOOP_SERVER_URL, do we really need a seperate port setting
> as well (note I thjnk the url will take president over the port setting if
> configured like this)
> 
> Xref
> http://mxr.mozilla.org/mozilla-central/source/browser/components/loop/test/
> functional/serversetup.py#34

It won't, because that doesn't get imported from the environment either; it's set in config.py.
I don't think importing that from the environment is a good idea, though, because I (and I presume) others keep it set by default in the environment for the development copy of the server.  Things are somewhat tangled here, and could be made cleaner, but given our environment shift, I'm not sure now is the right moment to do that.

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d3e4ad707400