1222180 - Messaging a contact that does not have a phone number or email address prompts a misleading error message

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[[:VladimirBelonenko]]

Attachment: logcat_20151105_1314.txt

Description:
Sending out message with a contact that has no phone number and email address. Error message: should say 'or' not 'and'.

Repro Steps:
1) Update a Flame to 20151105030203
2) Create Contact just with name
3) Open Messages app and send new message.
4) Add contact To + and Select your contact
5) Observe that Error Message says This contact does not have a phone number and email address.

Actual:
Error Message appears to have a grammar mistake with a word 'and'

Expected:
Error Message should have word 'or' instead of 'and'.

Environmental Variables:
Device: Flame Master 2.6 kk full flash
Build ID: 20151105030203
Gaia: 607b9c5db7fdbbafc16a572e7c319baa266a3372
Gecko: 59c648a3f95524cb1ee42f2306c1db2698d35258
Gonk: 205ac4204bbbb2098a8046444acba551ba5dc75a
Version: 45.0a1 (Master)
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:45.0) Gecko/45.0 Firefox/45.0

Notes: Error message should say: This contact does not have a phone number or email address.

Repro frequency: 3/3
See attached: video clip and logcat

Comment 1

[[:VladimirBelonenko]]

This issue still occurs on Flame 2.5, Flame 2.2, and Aries 2.6
Result: Error Message appears to have a grammar mistake with a word 'and'

Environmental Variables:
Device: Flame Master 2.5 kk full flash 
Build ID: 20151105004500
Gaia: 47da49f8206788d70d834c3a63d9245d50c89103
Gecko: 5c9fd135d4309239794126f1942d6e7aa8b3579c
Gonk: 205ac4204bbbb2098a8046444acba551ba5dc75a
Version: 45.0a1 (Master)
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:45.0) Gecko/45.0 Firefox/45.0

Environmental Variables:
Device: Flame 2.2 kk full flash
Build ID: 20151105032504
Gaia: 885647d92208fb67574ced44004ab2f29d23cb45
Gecko: 9d91dfad5e16
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 37.0 (2.2)
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Environmental Variables:
Device: Aries Master 2.6 kk full flash
Build ID: 20151105134116
Gaia: c3be747b993f0c70e7b93a709ef691383c88fc01
Gecko: 61dcc13d0848230382d5c85cdcf6721a05ee37c6
Gonk: a19052e4389c3ae2d8fc3e7a74a475401baacc56
Version: 45.0a1 (Master)
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:45.0) Gecko/45.0 Firefox/45.0

Comment 2

[kumar rishav (:rishav_)]

Bug related to Gaia::contacts component
This string need to change.
https://github.com/mozilla-b2g/gaia/blob/master/apps/communications/contacts/locales/contacts.en-US.properties#L23

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] comzeradd:bug-1222180 > mozilla-b2g:master

Comment 4

[Nikos Roussos [:comzeradd]]

Attachment: Pull Request

Comment 5

[kumar rishav (:rishav_)]

Comment on attachment 8687132 [details] [review]
Pull Request

Hey Francisco,
Have a look on patch. It seems fine to me.
If it's okay for you, then please merge it :) 

Thanks

Comment 6

[Julien Wajsberg [:julienw]]

Comment on attachment 8687132 [details] [review]
Pull Request

Just pass the r request to francisco :)

Comment 7

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8687132 [details] [review]
Pull Request

LGTM

Thanks for the contribution!

Comment 8

[Francisco Jordano [:arcturus] [:francisco]]

Landed in master:

https://github.com/mozilla-b2g/gaia/commit/000684f54da0910706a90b0b0cebc7891b2b8e3a

Comment 9

[Francisco Jordano [:arcturus] [:francisco]]

Uplift to NGA branch:

63b4717

Comment 10

[Verson Xiong (Leave from Mozilla)]

Attachment: Verified_v2.6_Aries.png

This bug has been verified as "pass" on the latest build of Aries KK v2.6 and Flame KK v2.6 512mb by the STR in comment 0.

Actual results: Error Message use word 'or' instead of 'and'.

See attachment: Verified_v2.6_Aries.png
Reproduce rate: 0/10

Device: Aries KK v2.6(master) (Pass)
Build ID               20151118150439
Gaia Revision          cba7e4b86361af31b153cfebaf99900e0b860f7b
Gaia Date              2015-11-18 09:45:49
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/1d6155d7e6c91fa5ec1ef6927f3d3a044187896d
Gecko Version          45.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151118.142334
Firmware Date          Wed Nov 18 14:23:42 UTC 2015
Bootloader             s1

Device: Flame KK v2.6(master) 512mb (Pass)
Build ID               20151119150204
Gaia Revision          94a821b49f4dca3f9321cd80e13c44c4a6696952
Gaia Date              2015-11-19 15:35:33
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/cc325db44f6f8a58604d60b746c140e73f3d8216
Gecko Version          45.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151119.182720
Firmware Date          Thu Nov 19 18:27:32 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0