Allow /api/ to be served by Olympia (for the AMO API)

RESOLVED FIXED

Status

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: kumar, Assigned: jason)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

This middleware change allowed Olympia to serve the AMO API from /api/ instead of /en-US/firefox/api/ : https://github.com/mozilla/olympia/issues/859

However, there was a historic nginx rule that routed addons.mozilla.org/api/ to services.addons.mozilla.org in https://github.com/mozilla-services/puppet-config/blob/master/amo/modules/amo_proxy/templates/nginx.addons.conf.erb#L243-L245 

Jason says this is not needed and confirmed by seeing that no one has accessed /api/ in the past 30 days. There is also no evidence in the current Firefox code base that any code is accessing the API this way: https://dxr.mozilla.org/mozilla-central/search?q=addons.mozilla.org&redirect=true&case=false

Comment 1

3 years ago
You could also maybe just make only /api/v3/ be served by olympia.

The main /api/ documentation is here: https://developer.mozilla.org/en-US/docs/addons.mozilla.org_%28AMO%29_API_Developers'_Guide/The_generic_AMO_API, and uses the services domain, so I wouldn't be opposed to just moving all of /api/.
(Assignee)

Comment 2

3 years ago
https://github.com/mozilla-services/puppet-config/pull/1638 merged to master and deployed on -dev and stage.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Assignee)

Updated

3 years ago
Assignee: nobody → jthomas
You need to log in before you can comment on or make changes to this bug.