Closed Bug 1222265 Opened 4 years ago Closed 4 years ago

Intermittent unicode-attribute-selector.html | image comparison (==), max difference: 25, number of differing pixels: 546

Categories

(Core :: Layout, defect)

45 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox45 --- fixed
firefox46 --- fixed

People

(Reporter: KWierso, Assigned: jfkthame)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

More of the same. ISTM that basically any testcase that depends on rendering of <input> or <textarea> elements (or other controls?) is liable to be unreliable until we get the underlying Gtk3-form-controls bug fixed; but I admit I don't much like sprinkling -moz-appearance:none everywhere like this, as it means our tests are increasingly diverging from what's usually seen by users in the wild. :(
Attachment #8707381 - Flags: review?(dholbert)
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Comment on attachment 8707381 [details] [diff] [review]
Use -moz-appearance:none in layout/reftests/unicode testcases to work around unreliable Gtk3 form-control rendering

Review of attachment 8707381 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, though you should use /* */ for CSS comments, not //. The "//" syntax kind of works, but only if you get lucky.  More on that here:
  http://www.xanthir.com/b4U10

r=me with that fixed
Attachment #8707381 - Flags: review?(dholbert) → review+
(In reply to Daniel Holbert [:dholbert] from comment #9)
> Looks good, though you should use /* */ for CSS comments, not //. The "//"
> syntax kind of works, but only if you get lucky.

Duh, yes.... I know that, but my fingers are too used to typing C++ and it tends to slip through. Thanks for catching!
https://hg.mozilla.org/integration/mozilla-inbound/rev/fcdec07e95a3db3bd378d3cbf4b92eec8739c99f
Bug 1222265 - Use -moz-appearance:none in layout/reftests/unicode testcases to work around unreliable Gtk3 form-control rendering. r=dholbert
https://hg.mozilla.org/integration/mozilla-inbound/rev/3a8ebac26ca580cf5235a37a2ff80c13ac7b67e6
Bug 1222265 - Use -moz-appearance:none in layout/reftests/unicode testcases to work around unreliable Gtk3 form-control rendering. r=dholbert
https://hg.mozilla.org/mozilla-central/rev/3a8ebac26ca5
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Flags: needinfo?(jfkthame)
Whiteboard: [checkin-needed-aurora]
Whiteboard: [checkin-needed-aurora]
You need to log in before you can comment on or make changes to this bug.