1222366 - [TV Browser] TV should keep the focus on the account field after pressing the X button

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TV::Browser, defect, P3)

Description

[Cynthia Tang [:cynthiatang]]

Commit 1fb7e4b7904d577a1859b91269a85b363ddc2836
Merge: 079ead4 dd4a903
Author: gasolin <[e-mail]>
Date:   Fri Nov 6 10:30:49 2015 +0800

STR:
 1. Launch Browser
 2. Move cursor to Menu icon and press OK 
 3. Select "Sign in to Sync" and press OK
 4. Enter "abcd" > Press "Right" > Press OK

Expected Result:
 - The X button should be hidden
 - TV should keep the focus on the account field

Comment 1

[Evelyn Hung]

What is the actual result?

Comment 2

[yifan [:yifan][:yliao]]

(In reply to Evelyn Hung [:evelyn] from comment #1)
> What is the actual result?

The focus will still remain on the X button.

Comment 3

[Cynthia Tang [:cynthiatang]]

Actual Result:
 - It doesn't keep the focus on the account field. User have to move the cursor to the account field.
 - The X button would not be hidden

Comment 4

[GitHub Autolander Bot]

Attachment: [gaia] begeeben:1222366_tv_should_keep_the_focus > mozilla-b2g:master

Comment 5

[yifan [:yifan][:yliao]]

Comment on attachment 8692733 [details] [review]
[gaia] begeeben:1222366_tv_should_keep_the_focus > mozilla-b2g:master

Sean could you please help to review the patch? Thank you!

Comment 6

[Sean Lee [:seanlee][:weilonge]]

Comment on attachment 8692733 [details] [review]
[gaia] begeeben:1222366_tv_should_keep_the_focus > mozilla-b2g:master

LGTM. Thanks!

Comment 7

[yifan [:yifan][:yliao]]

Merged into master:
https://github.com/mozilla-b2g/gaia/commit/a33933d4acef32d276b4024b93c2985b5ce1843c

Comment 8

[yifan [:yifan][:yliao]]

Comment on attachment 8692733 [details] [review]
[gaia] begeeben:1222366_tv_should_keep_the_focus > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): 1194108
[User impact] if declined: Cumbersome UI
[Testing completed]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=925837deac35e950f71bc821df4bf9fa51f2cec5
[Risk to taking this patch] (and alternatives if risky): none
[String changes made]: none

Comment 9

[Josh Cheng [:josh]]

Comment on attachment 8692733 [details] [review]
[gaia] begeeben:1222366_tv_should_keep_the_focus > mozilla-b2g:master

Approve for TV 2.5

Comment 10

[Carsten Book [:Tomcat]]

for 2.5 https://github.com/mozilla-b2g/gaia/commit/fdd62e31080d73a3bab7286b4944001a0fa60da8