Closed Bug 1222369 Opened 9 years ago Closed 9 years ago

[Homescreen]The "Remove" dialog is shown as blank without any prompt text when the bookmark's name contains double quotation mark.

Categories

(Firefox OS Graveyard :: Gaia::Bookmark, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Bookmark
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:2.5+, b2g-v2.2 unaffected, b2g-v2.5 verified, b2g-master verified)

Status:
VERIFIED FIXED
Milestone:
2.6 S1 - 11/20
Project Flags:
blocking-b2g 2.5+
Tracking Flags:
Tracking Status
b2g-v2.2 --- unaffected
b2g-v2.5 --- verified
b2g-master --- verified

People

(Reporter: lixia, Assigned: cwiiis)

Details

(Whiteboard: [systemsfe])

Attachments

(5 files)

Flame_v2.6.3gp
3.84 MB, video/3gpp
Details
logcat_0637.txt
246.76 KB, text/plain
Details
[gaia] Cwiiis:bug1222369-bookmarks-remove-escaping > mozilla-b2g:master
46 bytes, text/x-github-pull-request
gmarty
: review+
mpotharaju
: approval-gaia-v2.5+
Details | Review
verified_Flame_v2.6.3gp
2.10 MB, video/3gpp
Details
verified_Flame_v2.5.png
27.90 KB, image/png
Details 
[1.Description]:
[Flame KK v2.5&2.6][Aries KK v2.6][Homescreen]When removing a bookmark whose name contains the double quotation mark, the "Remove" dialog is shown as blank without any text content except "Cancel" & "Remove" button. 

Found at: 06:37
Attach: logcat_0637.txt and Flame_v2.6.3gp.

[2.Testing Steps]: 
1. Pin a website to homescreen (e.g. "support.mozilla.org").
2. Long tap and edit the bookmark whose name contains the double quotation mark: " " " .
3. Long tap and try to remove the bookmark.

[3.Expected Result]: 
3. The "Remove" dialog on homescreen should be shown with "Remove support.mozilla.org" content and "Cancel" & "Remove" button. 

[4.Actual Result]: 
3. The "Remove" dialog is shown as blank without any text content except "Cancel" & "Remove" button. 

[5.Reproduction build]: 
Device: Flame KK 2.2 512mb (unaffected) 
Build ID               20151105032504
Gaia Revision          885647d92208fb67574ced44004ab2f29d23cb45
Gaia Date              2015-10-07 13:05:24
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/9d91dfad5e16
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151105.064912
Firmware Date          Thu Nov  5 06:49:23 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Flame KK 2.5 512mb (affected)
Build ID               20151105004500
Gaia Revision          47da49f8206788d70d834c3a63d9245d50c89103
Gaia Date              2015-11-03 21:48:23
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/5c9fd135d4309239794126f1942d6e7aa8b3579c
Gecko Version          45.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151105.043012
Firmware Date          Thu Nov  5 04:30:24 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Flame KK v2.6 512mb (master)(affected)
Build ID               20151105150203
Gaia Revision          f39a7a827c0c0f48087ff3ead94f61ae22523919
Gaia Date              2015-11-05 18:52:32
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/dae6c2b8fef8a2f504baab5dae7ccd59d57a1d9d
Gecko Version          45.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151105.182857
Firmware Date          Thu Nov  5 18:29:10 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.6 (master)(affected)
Build ID               20151105235624
Gaia Revision          f39a7a827c0c0f48087ff3ead94f61ae22523919
Gaia Date              2015-11-05 18:52:32
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/dae6c2b8fef8a2f504baab5dae7ccd59d57a1d9d
Gecko Version          45.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151105.231433
Firmware Date          Thu Nov  5 23:14:41 UTC 2015
Bootloader             s1

[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
Free Test

[8.Note]:
After step 3, if you tap the "Remove" button, the bookmark will be removed successfully.
Attached video Flame_v2.6.3gp — 

    
    

    
  

      
      
      
      

        Attached file
          
        logcat_0637.txt
        — 
      

    


  

    
    

    
  
Removing pinned sites is handled by the remove-bookmark activity - good find, I'll take a quick look and see if it's something simple...
Component: Gaia::Homescreen → Gaia::Bookmark

    
  
Assignee: nobody → chrislord.net
Status: NEW → ASSIGNED

    
    

    
  
[Blocking Requested - why for this release]: Possible security implications? (probably not, but this is basically an incorrect unescaping bug, so maybe?)
blocking-b2g: --- → 2.5?

    
    

    
  
Comment on attachment 8684171 [details] [review]
[gaia] Cwiiis:bug1222369-bookmarks-remove-escaping > mozilla-b2g:master

Bookmarks doesn't really seem to have an owner... Sorry gmarty :)

        Attachment #8684171 -
        Flags: review?(gmarty)

    
    

    
  
While I don't think verticalhome used this activity, I don't think this is a regression in bookmarks.
Keywords: regression
Whiteboard: [systemsfe]

    
    

    
  
Comment on attachment 8684171 [details] [review]
[gaia] Cwiiis:bug1222369-bookmarks-remove-escaping > mozilla-b2g:master

That looks perfect!

        Attachment #8684171 -
        Flags: review?(gmarty) → review+

    
    

    
  
Merged: https://github.com/mozilla-b2g/gaia/commit/b9098cc03968e3cc71cd0f379713b522398311bc
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED

    
    

    
  
Comment on attachment 8684171 [details] [review]
[gaia] Cwiiis:bug1222369-bookmarks-remove-escaping > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: Missing UI, but also possible security implications?
[Testing completed]: Tested manually and added automated unit testing
[Risk to taking this patch] (and alternatives if risky): Low risk
[String changes made]: None

        Attachment #8684171 -
        Flags: approval-gaia-v2.5?
blocking-b2g: 2.5? → 2.5+

    
    

    
  
Comment on attachment 8684171 [details] [review]
[gaia] Cwiiis:bug1222369-bookmarks-remove-escaping > mozilla-b2g:master

Approved for 2.5 uplift

        Attachment #8684171 -
        Flags: approval-gaia-v2.5? → approval-gaia-v2.5+

    
    

    
  
This bug has been verified as "pass" on the latest build of Flame KK 2.6 and Aires KK 2.6 by the STR in comment 0.

Actual results: The "Remove" dialog on homescreen is shown with correct prompt content and "Cancel" & "Remove" button. 
See attachment: verified_Flame_v2.6.3gp
Reproduce rate: 0/10


Device: Flame KK v2.6 512mb (master)(Pass)
Build ID               20151108150206
Gaia Revision          c3436122d678911d04b8f491724596116890ff9b
Gaia Date              2015-11-06 18:22:03
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/e2a910c048dc82fc3be53475f18e7f81f03e377b
Gecko Version          45.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151108.183921
Firmware Date          Sun Nov  8 18:39:33 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.6 (master)(Pass)
Build ID               20151107001102
Gaia Revision          c3436122d678911d04b8f491724596116890ff9b
Gaia Date              2015-11-06 18:22:03
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/e2a910c048dc82fc3be53475f18e7f81f03e377b
Gecko Version          45.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151106.232924
Firmware Date          Fri Nov  6 23:29:32 UTC 2015
Bootloader             s1
QA Whiteboard: [MGSEI-Triage+]

          status-b2g-master:
          affected → verified
Target Milestone: --- → 2.6 S1 - 11/20

    
    

    
  
This bug has been verified as "pass" on the latest build of Flame KK 2.5 and Aires KK 2.5 by the STR in comment 0.

Actual results: When the bookmark's name contains double quotation mark, the "Remove" dialog on homescreen is shown with correct prompt content and "Cancel" & "Remove" button.
See attachment: verified_Flame_v2.5.png
Reproduce rate: 0/10


Device: Flame KK 2.5  512mb user build (Pass)
Build ID               20151116173604
Gaia Revision          9473dbcbebf4e758a3b73200968efc69071b4312
Gaia Date              2015-11-16 15:49:25
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/17877d161e5f62726027ee70101a7004dcad5a69
Gecko Version          44.0a2
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151116.164743
Firmware Date          Mon Nov 16 16:47:52 UTC 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.5 user build (Pass)
Build ID               20151116174534
Gaia Revision          9473dbcbebf4e758a3b73200968efc69071b4312
Gaia Date              2015-11-16 15:49:25
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/17877d161e5f62726027ee70101a7004dcad5a69
Gecko Version          44.0a2
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151116.165317
Firmware Date          Mon Nov 16 16:53:25 UTC 2015
Bootloader             s1
Status: RESOLVED → VERIFIED

          status-b2g-v2.5:
          fixed → verified

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: