1222383 - Send synthesized long tap event in text selection JS marionette test

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Jeremy Chen ([e-mail])]

Long tap to select texts is an essential step for testing functionality of text selection. In JS marionette, we use a series of chained actions to simulate long tap; however, some of the actions are not easy to understand. For example, calling moveByOffset(0, 0) in [1] looks meaningless, but it is a necessary step to prevent waking contextmenu. Thanks to Ting-Yu's work in Bug 1209841, now we can send synthesized long tap event in JS marionette test.

In this bug, I'm planning to use synthesized long tap event to refactor longPress() in [2] and longPressByPosition() in [3].


[1] http://mxr.mozilla.org/gaia/source/apps/system/test/marionette/lib/text_selection.js#126
[2] http://mxr.mozilla.org/gaia/source/apps/system/test/marionette/lib/text_selection.js#118
[3] http://mxr.mozilla.org/gaia/source/apps/system/test/marionette/lib/text_selection.js#123

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] chenpighead:1222383 > mozilla-b2g:master

Comment 2

[Jeremy Chen ([e-mail])]

Comment on attachment 8688374 [details] [review]
[gaia] chenpighead:1222383 > mozilla-b2g:master

Hi Etienne, could you help review this? Thanks.

Comment 3

[Etienne Segonzac (:etienne)]

Comment on attachment 8688374 [details] [review]
[gaia] chenpighead:1222383 > mozilla-b2g:master

r=me with nit (we should maybe squash the commits into 1 too)

Comment 4

[Jeremy Chen ([e-mail])]

(In reply to Etienne Segonzac (:etienne) from comment #3)
> Comment on attachment 8688374 [details] [review]
> [gaia] chenpighead:1222383 > mozilla-b2g:master
> 
> r=me with nit (we should maybe squash the commits into 1 too)

The comments have been addressed, and I also squash the commits into 1 as well.
Thank you for the review.

Comment 5

[Carsten Book [:Tomcat]]

https://github.com/mozilla-b2g/gaia/commit/75e7f6fcb4ff3b52786fabf9cab0edb18174d953