Closed
Bug 1222406
Opened 10 years ago
Closed 10 years ago
Mozreview doesn't display autoland action results correctly
Categories
(MozReview Graveyard :: General, defect)
MozReview Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mdoglio, Assigned: mdoglio)
References
Details
Attachments
(1 file)
The autoland action results panel only renders correctly in the review summary page. Now that bug 1221225 is fixed, that page is not easily accessible anymore and the results panel doesn't fully render on the commit pages.
| Assignee | ||
Updated•10 years ago
|
Assignee: nobody → mdoglio
Status: NEW → ASSIGNED
| Assignee | ||
Comment 1•10 years ago
|
||
mozreview: render autoland results on child review (bug 1222406); r?dminor
The autoland results template is rendered on every review page but it's javascript
code used to run only on the parent. This patch moves the autoland results js code
to autoland.js, together with the code that triggers a new autoland request.
Attachment #8685550 -
Flags: review?(dminor)
Updated•10 years ago
|
Attachment #8685550 -
Flags: review?(dminor) → review+
Comment 2•10 years ago
|
||
Comment on attachment 8685550 [details]
MozReview Request: mozreview: render autoland results on child review (bug 1222406); r=dminor
https://reviewboard.mozilla.org/r/24831/#review22345
lgtm
| Assignee | ||
Comment 4•10 years ago
|
||
Comment on attachment 8685550 [details]
MozReview Request: mozreview: render autoland results on child review (bug 1222406); r=dminor
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/24831/diff/1-2/
Attachment #8685550 -
Attachment description: MozReview Request: mozreview: render autoland results on child review (bug 1222406); r?dminor → MozReview Request: mozreview: render autoland results on child review (bug 1222406); r=dminor
| Assignee | ||
Comment 5•10 years ago
|
||
Comment on attachment 8685550 [details]
MozReview Request: mozreview: render autoland results on child review (bug 1222406); r=dminor
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/24831/diff/2-3/
| Assignee | ||
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•9 years ago
|
Product: Developer Services → MozReview
You need to log in
before you can comment on or make changes to this bug.
Description
•