1222415 - Update l20n.js to 3.4.1

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::L10n, defect)

Description

[Staś Małolepszy :stas]

L20n 3.4.1 for Gaia is transpiled via Babel so that classes work in non-nightly Gecko.  This will help fix bug 1222159.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] stasm:1222415-l20n-3.4.1 > mozilla-b2g:master

Comment 2

[Staś Małolepszy :stas]

I tried to reproduce the failing Gij tests with Mulet builds based on b2g44 and Gaia v2.5, but I couldn't.  Should we try to land this and see if it helps?

Comment 3

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8684202 [details] [review]
[gaia] stasm:1222415-l20n-3.4.1 > mozilla-b2g:master

r+

Comment 4

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8684202 [details] [review]
[gaia] stasm:1222415-l20n-3.4.1 > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): we use `class` ES6 feature which has not been riding 44 train. 
[User impact] if declined: l20n.js doesn't work on gecko 44
[Testing completed]: device
[Risk to taking this patch] (and alternatives if risky): none
[String changes made]: none

I'm wondering if we need to land it on master, or maybe we can just land it on 2.5 branch. Opinions?

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

Landed on master - https://github.com/mozilla-b2g/gaia/commit/4fd921d78543a3ca36e3a998adf30d2dbb0d53ea

Comment 6

[Oleg Zasypkin [:azasypkin]]

I can confirm that this PR fixed bug 1222159, bug 1222163 and bug 1222186.

Thanks!

Comment 7

[Mahendra Potharaju [:mahe]]

Comment on attachment 8684202 [details] [review]
[gaia] stasm:1222415-l20n-3.4.1 > mozilla-b2g:master

Approved to uplift for 2.5

Comment 8

[Zibi Braniecki [:zbraniecki][:gandalf]]

And landed in 2.5 https://github.com/mozilla-b2g/gaia/commit/577948202ae12154524a2bd2bd6d467838ad50b8

Comment 9

[Julien Wajsberg [:julienw]]

Gandalf, remember how uplifts should work:

* mark "resolved fixed" once we land on master
* let the sheriffs do the uplift to v2.5 themselves

The goal is to avoid any mistakes on the branch.

Comment 10

[Julien Wajsberg [:julienw]]

Fixed the issue, see https://treeherder.mozilla.org/#/jobs?repo=mozilla-b2g44_v2_5&revision=ae7b8b1fd9e1