Closed Bug 1222417 Opened 4 years ago Closed 4 years ago

Make filter input prettier

Categories

(DevTools :: Memory, defect)

defect
Not set

Tracking

(firefox45 fixed)

VERIFIED FIXED
Firefox 45
Tracking Status
firefox45 --- fixed

People

(Reporter: ntim, Assigned: hanue, Mentored)

References

(Blocks 1 open bug)

Details

(Whiteboard: [good first bug][lang=css])

Attachments

(2 files)

The filter input looks really ugly right now. Adding the .devtools-searchinput class would greatly fix the issue, in addition with "align-self: stretch" and "margin: 2px" to make sure it doesn't appear tiny.
Has STR: --- → irrelevant
(In reply to Tim Nguyen [:ntim] from comment #0)
> The filter input looks really ugly right now. Adding the
> .devtools-searchinput class would greatly fix the issue
You'll need to add className: "devtools-searchinput" here: https://dxr.mozilla.org/mozilla-central/source/devtools/client/memory/components/toolbar.js#81
While someone is touching this code, the previous className values should be using normal double quotes (className: "take-snapshot devtools-button" and className: "select-breakdown"), as they perform faster.

> in addition with "align-self: stretch" and "margin: 2px" to make sure it doesn't appear tiny.
You'll need to create a new rule here: https://dxr.mozilla.org/mozilla-central/source/devtools/client/themes/memory.css#102 with the selector "#filter".


Eduard, I've seen you taking a few similar bugs, are you interested in taking this one ?
Mentor: ntim.bugs
Flags: needinfo?(hanue)
Whiteboard: [good first bug][lang=css]
Hello Tim! Sure, no problem. I will have a look on it tonight.
Flags: needinfo?(hanue)
Hello Tim! As promised, you will find attached the patch for this bug.

Best regards,

Eduard
Attachment #8685691 - Flags: review?(ntim.bugs)
Assignee: nobody → hanue
Status: NEW → ASSIGNED
Comment on attachment 8685691 [details] [diff] [review]
rev1 - Filter input fixes in toolbar.js and memory.css

Review of attachment 8685691 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch ! Looks good to me, I'll ask a peer to review this as well.
Attachment #8685691 - Flags: review?(vporof)
Attachment #8685691 - Flags: review?(ntim.bugs)
Attachment #8685691 - Flags: review+
Attached image Screenshot
Attachment #8685691 - Flags: review?(vporof) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/9dcc5c1e9594
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
I have reproduced this bug on Nightly 45.0a1 (2015-11-06) on ubuntu 14.04 LTS, 32 bit!

The bug's fix is now verified on Latest Beta 45.0b3!

Build ID: 20160204142810
User Agent: Mozilla/5.0 (X11; Linux i686; rv:45.0) Gecko/20100101 Firefox/45.0
QA Whiteboard: [testday-20160205]
Status: RESOLVED → VERIFIED
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.