1222417 - Make filter input prettier

Status: VERIFIED FIXED

(DevTools :: Memory, defect)

Description

[Tim Nguyen :ntim]

The filter input looks really ugly right now. Adding the .devtools-searchinput class would greatly fix the issue, in addition with "align-self: stretch" and "margin: 2px" to make sure it doesn't appear tiny.

Comment 1

[Tim Nguyen :ntim]

(In reply to Tim Nguyen [:ntim] from comment #0)
> The filter input looks really ugly right now. Adding the
> .devtools-searchinput class would greatly fix the issue
You'll need to add className: "devtools-searchinput" here: https://dxr.mozilla.org/mozilla-central/source/devtools/client/memory/components/toolbar.js#81
While someone is touching this code, the previous className values should be using normal double quotes (className: "take-snapshot devtools-button" and className: "select-breakdown"), as they perform faster.

> in addition with "align-self: stretch" and "margin: 2px" to make sure it doesn't appear tiny.
You'll need to create a new rule here: https://dxr.mozilla.org/mozilla-central/source/devtools/client/themes/memory.css#102 with the selector "#filter".


Eduard, I've seen you taking a few similar bugs, are you interested in taking this one ?

Comment 2

[Eduard Hanu]

Hello Tim! Sure, no problem. I will have a look on it tonight.

Comment 3

[Eduard Hanu]

Attachment: rev1 - Filter input fixes in toolbar.js and memory.css

Hello Tim! As promised, you will find attached the patch for this bug.

Best regards,

Eduard

Comment 4

[Tim Nguyen :ntim]

Comment on attachment 8685691 [details] [diff] [review]
rev1 - Filter input fixes in toolbar.js and memory.css

Review of attachment 8685691 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch ! Looks good to me, I'll ask a peer to review this as well.

Comment 5

[Tim Nguyen :ntim]

Attachment: Screenshot

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/9dcc5c1e9594

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9dcc5c1e9594

Comment 8

[Khalid Syfullah Zaman [:khalid32]]

I have reproduced this bug on Nightly 45.0a1 (2015-11-06) on ubuntu 14.04 LTS, 32 bit!

The bug's fix is now verified on Latest Beta 45.0b3!

Build ID: 20160204142810
User Agent: Mozilla/5.0 (X11; Linux i686; rv:45.0) Gecko/20100101 Firefox/45.0