1222420 - AutoFinishGC is confusing

Status: RESOLVED FIXED

(Core :: JavaScript: GC, defect)

Description

[Jan de Mooij [:jandem]]

AutoFinishGC looks like a RAII class, so readers may think it means the destructor will finish the GC, or that we won't GC in its scope.

But it only has a constructor, so we could replace it with a function, js::FinishGC(rt) or something.

Comment 1

[Jon Coppeard (:jonco)]

Attachment: bug1222420-auto-finish-gc

I also found this strange.  I guess the reason is to finish the GC before the AutoTraceSession is constructed in AutoPrepareForTracing, but we can do that by wrapping it in a Maybe<>.

Comment 2

[Terrence Cole [:terrence]]

Comment on attachment 8729524 [details] [diff] [review]
bug1222420-auto-finish-gc

Review of attachment 8729524 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsgc.cpp
@@ -6732,5 @@
>          JS::PrepareForIncrementalGC(rt);
>          JS::FinishIncrementalGC(rt, JS::gcreason::API);
>      }
>  
> -    rt->gc.waitBackgroundSweepEnd();

\o/  Figured I'd miss at least one of these.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d6ce8d232178

Comment 4

[Wes Kocher (:KWierso)]

https://hg.mozilla.org/mozilla-central/rev/d6ce8d232178