Open Bug 1222467 Opened 9 years ago Updated 2 years ago

Check if the hal::Vibrate() visibility checks are really needed and remove them if not

Categories

(Core :: Hardware Abstraction Layer (HAL), defect, P3)

Product:
Core
Component:
Hardware Abstraction Layer (HAL)
Type:
defect

Tracking

()

People

(Reporter: gsvelto, Unassigned)

References

Details

(Keywords: foxfood) 

+++ This bug was initially created as a clone of Bug #1207221 +++

In bug 1207221 I noticed that before allowing navigator.vibrate() to call hal::Vibrate() we check if the calling window is visible. For some reason this check is repeated within hal::Vibrate() whenever the call is not coming via IPC (i.e. it originated from the main process). It's unclear why this is the case, the second check feels redundant unless there are direct callers of hal::Vibrate() that might live in the main process but would not go through navigator.vibrate(). If there aren't any of those callers then we should remove the check as there is a significant chunk of code that is solely required to implement it (besides it's terribly confusing).
Moving to p3 because no activity for at least 1 year(s).
See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage for more information
Priority: P2 → P3
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.