1222472 - (SeaMonkey) Use ObjDirPaths for GENERATED_INCLUDES and merge with LOCAL_INCLUDES

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Philip Chee]

See Bug 1221453 - Use Path classes for LocalInclude/GeneratedIncludes

> ==============================
> ERROR PROCESSING MOZBUILD FILE
> ==============================
> The error occurred while processing the following file:
>     c:/t1/hg/comm-central/suite/app/moz.build
> The error was triggered on line 14 of this file:
>     GENERATED_INCLUDES += ['/build']
> The underlying problem is an attempt to read a reserved UPPERCASE variable that does not exist.
> The variable read causing the error is:
>     GENERATED_INCLUDES
> Maybe you meant GENERATED_FILES or GENERATED_WEBIDL_FILES?
> Please use
>     LOCAL_INCLUDES += [ '!foo' ]
> instead of
>     GENERATED_INCLUDES += [ 'foo' ]

Comment 1

[Philip Chee]

Attachment: Patch v1 Fix GENERATED_INCLUDES r=clokep a=ewong CLOSED TREE

Comment 2

[Patrick Cloke [:clokep]]

Comment on attachment 8684262 [details] [diff] [review]
Patch v1 Fix GENERATED_INCLUDES r=clokep a=ewong CLOSED TREE

Review of attachment 8684262 [details] [diff] [review]:
-----------------------------------------------------------------

In the spirit of asking forgiveness and not permission, I'm going to say rs=me. Simple port for a bustage fix that matches bug 1222479 (which I already reviewed).

Comment 3

[Justin Wood (:Callek)]

err I think this is a dupe of Bug 1222643 (or vice versa)

Comment 4

[Edmund Wong (:ewong)]

(In reply to Justin Wood (:Callek) from comment #3)
> err I think this is a dupe of Bug 1222643 (or vice versa)

oh drat.  I missed this as I didn't think it was a Mailnews Core build
config bug.

I'll back out my patch, since we're busted anyway due to
other bugs.

Comment 6

[Edmund Wong (:ewong)]

Comment on attachment 8684262 [details] [diff] [review]
Patch v1 Fix GENERATED_INCLUDES r=clokep a=ewong CLOSED TREE

Pushed  to comm-central:
 https://hg.mozilla.org/comm-central/rev/3f7a1101dcd8

PS: Sorry for the spelling mistake in the commit msg.

Comment 7

[Edmund Wong (:ewong)]

Comment on attachment 8684262 [details] [diff] [review]
Patch v1 Fix GENERATED_INCLUDES r=clokep a=ewong CLOSED TREE

Backed out the previous patch: 
  https://hg.mozilla.org/comm-central/rev/9d4b78f58765

Pushed fixed comment patch:
 https://hg.mozilla.org/comm-central/rev/93a4f49f658c

Comment 8

[Philip Chee]

Comment on attachment 8684262 [details] [diff] [review]
Patch v1 Fix GENERATED_INCLUDES r=clokep a=ewong CLOSED TREE

Bug 1222591 seems to have caused Bug 1221453

Comment 9

[Philip Chee]

(In reply to Philip Chee from comment #8)
> Comment on attachment 8684262 [details] [diff] [review]
> Patch v1 Fix GENERATED_INCLUDES
> 
> Bug 1222591 seems to have caused Bug 1221453
I mean Bug 1221453 seems to have caused Bug 1222591

Comment 10

[Philip Chee]

Comment on attachment 8684262 [details] [diff] [review]
Patch v1 Fix GENERATED_INCLUDES r=clokep a=ewong CLOSED TREE

Pushed to comm-central http://hg.mozilla.org/comm-central/rev/93a4f49f658c