1222531 - turn off -Wextra-tokens on clang-cl in accessible/ directories

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Nathan Froyd [:froydnj]]

The Windows MIDL code generator creates things like:

    #endif !_MIDL_USE_GUIDDEF_

which clang-cl complains about.  MSVC doesn't, so turn this warning off.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: turn off -Wextra-tokens on clang-cl in accessible/ directories

This is technically a build config change, but I think Trevor can review this.

Comment 2

[Trevor Saunders (:tbsaunde)]

Comment on attachment 8684317 [details] [diff] [review]
turn off -Wextra-tokens on clang-cl in accessible/ directories

yeah, I'm comfortable saying this is fine.  I'm kind of suprised you didn't need this in other directories, especially accessible/windows/uia/ but maybe only some midl generated files have this?

As gross as this is I wonder if clang-cl should generally not emit this warning by default?

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6490203bb10a

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6490203bb10a