1222548 - Allow passing a relative directory to --source

Status: RESOLVED INVALID

(Release Engineering :: Applications: MozharnessCore, defect)

Description

[Steve Fink [:sfink] [:s:]]

I have had two different people attempt to use the spidermonkey_build.py script now and run afoul of this.

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Allow passing a relative directory to --source

Comment 2

[Jordan Lund (:jlund)]

Comment on attachment 8684362 [details] [diff] [review]
Allow passing a relative directory to --source

Review of attachment 8684362 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm.

do we need self.config['srcdir'] at all? or can we just do the following in pre_config_lock:
`self.config['source'] = os.path.abspath(self.config['source'])`?

and then always reference self.config['source'] whether it gets its value from a cfg file or overrided by cmd line --source?

Comment 3

[Jordan Lund (:jlund)]

again sorry for delays. b2g 2.5 release took all my time this week.

Comment 4

[Steve Fink [:sfink] [:s:]]

I'm not really using this script for anything anymore. I've switched to shell scripts under TC. And if I switch back to python, I'm unlikely to reuse this script.