updater.app is copied incorrectly for mochitest chrome tests

RESOLVED FIXED in Firefox 46

Status

RESOLVED FIXED
3 years ago
11 months ago

People

(Reporter: spohl, Assigned: spohl)

Tracking

unspecified
mozilla46
Unspecified
Mac OS X
Points:
---

Firefox Tracking Flags

(firefox46 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Noticed this while working on the new tests for bug 394984. The current directory structure of the updater for mochitest chrome looks like:
{objdir}/_tests/testing/mochitest/chrome/toolkit/mozapps/update/tests/data/updater.app/updater.app/Contents/
but should be:
{objdir}/_tests/testing/mochitest/chrome/toolkit/mozapps/update/tests/data/updater.app/Contents/

This results in a failure to spawn the updater in mochitest chrome tests:
"Process spawn failed with code 2!", meaning the file doesn't exist (see MacLaunchHelper.mm).
(Assignee)

Comment 1

3 years ago
Created attachment 8684360 [details] [diff] [review]
Patch

Sending to try before requesting review.
(Assignee)

Updated

3 years ago
Attachment #8684360 - Attachment description: bug1222555 → Patch
(Assignee)

Comment 3

3 years ago
Comment on attachment 8684360 [details] [diff] [review]
Patch

Try is green.
Attachment #8684360 - Flags: review?(robert.strong.bugs)
Comment on attachment 8684360 [details] [diff] [review]
Patch

Looks good to me but you should get a build peer to look at this as well since they want to see changes like this.
Attachment #8684360 - Flags: review?(robert.strong.bugs) → review+
This is fine, it's not making any significant change to the Makefile. (We're trying to remove everything from Makefiles, but this isn't going to hurt that effort.)
(Assignee)

Comment 7

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/35fc1b57c578dce0539f4dbcca9802f986164682
Bug 1222555: Copy updater.app to the proper location for app update mochitest chrome tests. r=rstrong,ted
(Assignee)

Comment 8

3 years ago
(In reply to Stephen A Pohl [:spohl] from comment #7)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/
> 35fc1b57c578dce0539f4dbcca9802f986164682
> Bug 1222555: Copy updater.app to the proper location for app update
> mochitest chrome tests. r=rstrong,ted

I pushed this with r=rstrong,ted to make it clear in the commit notes that a build peer had a look at this patch (thanks, Ted!).

Comment 9

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/35fc1b57c578
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox46: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Component: Mochitest Chrome → Mochitest
Product: Testing → Testing
You need to log in before you can comment on or make changes to this bug.