Fix dom/workers/test/test_xhr_parameters.html and test_tcpsocket_enabled_with_perm.html to work with e10s

RESOLVED FIXED in Firefox 45

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: mccr8, Assigned: mccr8)

Tracking

(Blocks: 1 bug)

Trunk
mozilla45
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(e10s+, firefox45 fixed)

Details

Attachments

(3 attachments)

(Assignee)

Description

3 years ago
It uses SpecialPowers.addPermission() instead of SpecialPowers.pushPermissions().
(Assignee)

Comment 1

3 years ago
test_tcpsocket_enabled_with_perm.html has the same problem, and they are both simple fixes.
Summary: Fix dom/workers/test/test_xhr_parameters.html to work with e10s → Fix dom/workers/test/test_xhr_parameters.html and test_tcpsocket_enabled_with_perm.html to work with e10s

Updated

3 years ago
Blocks: 984139
tracking-e10s: --- → +
(Assignee)

Comment 2

3 years ago
Created attachment 8685467 [details] [diff] [review]
part 1 - Fix use of addPermission in test_tcpsocket_enabled_with_perm.html and test_xhr_parameters.html.

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=002fe94dc8fe
Attachment #8685467 - Flags: review?(mrbkap)
(Assignee)

Comment 3

3 years ago
Created attachment 8685468 [details] [diff] [review]
part 2 - Add some comments about failing tests.
Attachment #8685468 - Flags: review?(mrbkap)
(Assignee)

Comment 4

3 years ago
Created attachment 8685469 [details] [diff] [review]
part 3 - Enable a single test in uriloader.

This test passes with e10s. The other two do not.
Attachment #8685469 - Flags: review?(mrbkap)
Comment on attachment 8685467 [details] [diff] [review]
part 1 - Fix use of addPermission in test_tcpsocket_enabled_with_perm.html and test_xhr_parameters.html.

Review of attachment 8685467 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/network/tests/test_tcpsocket_enabled_with_perm.html
@@ +17,5 @@
>    the tcp-socket permission has been granted.
>  **/
>  SimpleTest.waitForExplicitFinish();
> +SpecialPowers.pushPrefEnv({"set": [['dom.mozTCPSocket.enabled', true]]}, function() {
> +  SpecialPowers.pushPermissions([{type: "tcp-socket", allow: true, context: document}], runTest); });

Nit: I'd indent this as:

SpecialPowers.pushprefEnv(..., function() {
  SpecialPowers.pushPermissions(...);
});
Attachment #8685467 - Flags: review?(mrbkap) → review+
Attachment #8685468 - Flags: review?(mrbkap) → review+
Attachment #8685469 - Flags: review?(mrbkap) → review+
(Assignee)

Comment 6

3 years ago
(In reply to Blake Kaplan (:mrbkap) (please use needinfo!) from comment #5)
> Nit: I'd indent this as:

Oh yeah, that's less weird. Fixed.

Comment 8

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/0a2ab9e74af2
https://hg.mozilla.org/mozilla-central/rev/4796c2145d33
https://hg.mozilla.org/mozilla-central/rev/e915959648c4
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox45: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.