1222569 - fix various problems in gfx/ turned up by compiling with clang-cl

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Nathan Froyd [:froydnj]]

All of these are simple warnings with (seemingly) obvious fixes.  They're split
up very fine-grained, ideally to make them easier to review.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: fix initialization order in DataTextureSourceD3D9

Member fields are supposed to be initialized in the order they are
declared, but the constructors of DataTextureSourceD3D9 initialized
mFormat prior to mCompositor.  This is probably harmless, but it does
cause a warning on clang-cl, so let's fix it.

Comment 2

[Nathan Froyd [:froydnj]]

Attachment: fix initialization order in SourceSurfaceD2D1

Member fields are supposed to be initialized in the order they are
declared, but the constructor of SourceSurfaceD2D1 initialized
mDrawTarget prior to mDevice.  This is probably harmless, but it does
cause a warning on clang-cl, so let's fix it.

Comment 3

[Nathan Froyd [:froydnj]]

Attachment: fix initialization order in gfxWindowsPlatform.cpp

Comment 4

[Nathan Froyd [:froydnj]]

Attachment: fix -Wformat warning in gfxWindowsPlatform.cpp

Comment 5

[Nathan Froyd [:froydnj]]

Attachment: remove unused variable in gfxDWriteFonts.cpp

Comment 6

[Nathan Froyd [:froydnj]]

Attachment: remove unused variable in TextureD3D9.cpp

Comment 7

[Nathan Froyd [:froydnj]]

Attachment: remove unused variables in CompositorD3D9.cpp

None of the other DrawPrimitive calls in DrawQuad are checked, so
discaring the result from this call of DrawPrimitive seems OK.

Comment 8

[Nathan Froyd [:froydnj]]

Attachment: remove unused function from gfxPlatformFontList.cpp

Comment 9

[Nathan Froyd [:froydnj]]

Attachment: remove unused const variables from ExtendInputEffectD2D1.cpp

Comment 10

[Nathan Froyd [:froydnj]]

Attachment: remove unused variable from DrawTargetD2D1.cpp

Comment 11

[Bas Schouten (:bas.schouten)]

Comment on attachment 8684389 [details] [diff] [review]
remove unused variable in gfxDWriteFonts.cpp

Review of attachment 8684389 [details] [diff] [review]:
-----------------------------------------------------------------

If we're going to care about unused variable warnings, let's just enable them as errors on MSVC builds as well once we've removed them.

Comment 12

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dff6ad030963
https://hg.mozilla.org/integration/mozilla-inbound/rev/5f9ff9850912
https://hg.mozilla.org/integration/mozilla-inbound/rev/233e34b96012
https://hg.mozilla.org/integration/mozilla-inbound/rev/505f809cced1
https://hg.mozilla.org/integration/mozilla-inbound/rev/df9b89f3b023
https://hg.mozilla.org/integration/mozilla-inbound/rev/16f2f3a4ecc9
https://hg.mozilla.org/integration/mozilla-inbound/rev/688e27618992
https://hg.mozilla.org/integration/mozilla-inbound/rev/d1d04b257e61
https://hg.mozilla.org/integration/mozilla-inbound/rev/42163ce37977
https://hg.mozilla.org/integration/mozilla-inbound/rev/dbe8bf00bc3c

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/dff6ad030963
https://hg.mozilla.org/mozilla-central/rev/5f9ff9850912
https://hg.mozilla.org/mozilla-central/rev/233e34b96012
https://hg.mozilla.org/mozilla-central/rev/505f809cced1
https://hg.mozilla.org/mozilla-central/rev/df9b89f3b023
https://hg.mozilla.org/mozilla-central/rev/16f2f3a4ecc9
https://hg.mozilla.org/mozilla-central/rev/688e27618992
https://hg.mozilla.org/mozilla-central/rev/d1d04b257e61
https://hg.mozilla.org/mozilla-central/rev/42163ce37977
https://hg.mozilla.org/mozilla-central/rev/dbe8bf00bc3c